Re: [Gnu-arch-users] stamping files with revision id's.

[Robert Collins]

On Mon, 2003-10-20 at 07:03, Florian Weimer wrote:
> Robert Collins wrote:
> 
> > The timing is sensitive though:
> > I need to know the revision number that is being assigned in the
> > repository in order to updated the files that have changed. And if I
> > error, the revision number needs to be released and the commit aborted.
> > 
> > I'm not sure what to call a hook with this timing property.
> 
> I guess you need two hooks, a pre-commit hook and a hook which runs when
> a commit is aborted so that you can roll back your changes.

Huh? There will still be outstanding changes in the tree, and those
files will be updated against during the next commit attempt. I don't
see a need for a post-commit-failed hook -for this-. (Mind you a
commit-failed hook may be useful in general).

> In almost all cases, your approach will add spurious conflicts if you
> merge from several branches where this feature is used.  Maybe you can
> use something else to construct the data you need?

There are alternatives: =REVISION-ID in configs for instance. The useful
thing about inline revision details is that you can compile them into
runtime debug output.

Anyway, I'm not claiming to have though all the issues through: I've
seen many folk ask for this, and the back of my head came up with what I
sketched out..

For myself, I'm content without it.

Rob

-- 
GPG key available at: <http://members.aardvark.net.au/lifeless/keys.txt>.

signature.asc
Description: This is a digitally signed message part