Re: [PATCH] Using smsd to send multiline sms

[Pawel Kot]

Hi,

On Fri, Jul 18, 2008 at 14:02, Jan Derfinak <address@hidden> wrote:
> On Fri, 18 Jul 2008, Pawel Kot wrote:
>
> Hi.
>
>> Good point. Additionally there another problem. When there's an empty input
>> sms.user_data[0].u.text[strlen ((gchar *) sms.user_data[0].u.text) - 1]
>> will cause segfault. However that problem existed already before the patch.
>
> You're right. I thinking how to fix it. I can change code to not segfault
> but I'm not sure if there is any sense to send empty SMS so maybe better
> option is not to send any sms. What do you think?

I think it may have sense (however limited). I can imagine that for
automatic reporting systems sometimes you don't need any text. You may
need just to send an sms (empty or non empty or even empty may have
some special meaning) to some number to trigger an action.
On the other hand I'm not sure whether libgnokii supports empty SMS.

As the conclusion: I think we should allow sending an empty SMS from
SMSD. So if libgnokii fails with this, I'll fix it. And in the code
above I also think we should allow it.

take care,
pkot
-- 
Pawel Kot