[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Opensync-users] [PATCH] Delete message when write fails
From: |
Keith Packard |
Subject: |
Re: [Opensync-users] [PATCH] Delete message when write fails |
Date: |
Mon, 09 Jul 2007 13:40:40 -0700 |
On Mon, 2007-07-09 at 19:35 +0200, Pawel Kot wrote:
> Hi,
>
> On 7/9/07, Keith Packard <address@hidden> wrote:
> > @@ -2468,7 +2469,11 @@ static gn_error
> > NK6510_WritePhonebookLocation(gn_data > -
> > SEND_MESSAGE_BLOCK(NK6510_MSG_PHONEBOOK, count);
> > + if (sm_message_send (count, NK6510_MSG_PHONEBOOK, req, state))
> > return GN_ERR_NOTREADY;
> > + error = sm_block (NK6510_MSG_PHONEBOOK, data, state);
> > + if (error)
> > + (void) NK6510_DeletePhonebookLocation(data, state);
> > + return error;
>
> I'm not sure why you need this. Did you have a case when write failed
> but wrote the entry? Please show the log. The above may cause a
> problem when overwriting existing entries.
Oh, right, I intended to remove this code. I was having trouble with the
phone refusing to accept memory write requests, that was caused by the
phone getting quite confused and thinking that the internal memory was
full. Please don't use this patch.
--
address@hidden
signature.asc
Description: This is a digitally signed message part
- [PATCH] Speed up calendar fetch by not restarting note fetch, (continued)
- [PATCH] Speed up calendar fetch by not restarting note fetch, Keith Packard, 2007/07/09
- [PATCH] Delete message when write fails, Keith Packard, 2007/07/09
- [PATCH] Avoid duplicate phone and address entries, Keith Packard, 2007/07/09
- [PATCH] treat Postal entries as addresses, Keith Packard, 2007/07/09
- [PATCH] Set of address blocks counts as one data block., Keith Packard, 2007/07/09
- Re: [Opensync-users] [PATCH] treat Postal entries as addresses, Pawel Kot, 2007/07/09
- Re: [Opensync-users] [PATCH] Avoid duplicate phone and address entries, Pawel Kot, 2007/07/09
- Re: [Opensync-users] [PATCH] Avoid duplicate phone and address entries, Keith Packard, 2007/07/09
- Re: [Opensync-users] [PATCH] Avoid duplicate phone and address entries, Pawel Kot, 2007/07/09
- Re: [Opensync-users] [PATCH] Delete message when write fails, Pawel Kot, 2007/07/09
- Re: [Opensync-users] [PATCH] Delete message when write fails,
Keith Packard <=
- Re: [Opensync-users] [PATCH] Speed up calendar fetch by not restarting note fetch, Pawel Kot, 2007/07/09
- Re: [Opensync-users] [PATCH] Speed up calendar fetch by not restarting note fetch, Keith Packard, 2007/07/09
- Re: [Opensync-users] [PATCH] Speed up calendar fetch by not restarting note fetch, Pawel Kot, 2007/07/09
- Re: [Opensync-users] [PATCH] Support termination of repeating events, Pawel Kot, 2007/07/09
- Re: [Opensync-users] [PATCH] Account for phonebook blocks not sent due to limited packet space, Pawel Kot, 2007/07/09
- Re: [Opensync-users] [PATCH] Account for phonebook blocks not sent due to limited packet space, Pawel Kot, 2007/07/09
- Re: [Opensync-users] [PATCH] Account for phonebook blocks not sent due to limited packet space, Keith Packard, 2007/07/10
- Re: [Opensync-users] [PATCH] Limit phonebook to 1000 entries (as on 6131), Pawel Kot, 2007/07/09
- Re: [Opensync-users] [PATCH] Limit phonebook to 1000 entries (as on 6131), Jari Turkia, 2007/07/09
- Re: [Opensync-users] [PATCH] Limit phonebook to 1000 entries (as on 6131), Keith Packard, 2007/07/09