Re: smsc_timeout, is it possible to turn it off ?

[Krzysztof Śniadoch]

Daniele Forsi:
> Krzysztof Śniadoch wrote:
> > as I've noticed, it's quite rare when message isn't send, so the
> > confirmation only confirms something  that is almost always true.
>
> only you can decide the tradeoff between speed and reliability

Currently, I'm in situation where speed is the most important, however 
reliablity should be also high :P, but as I wrote above, it's very very 
unusuall when message after sent is rejected by the SMSC, so it seems that 
cutting off the confirmation can be nice thing to safe few seconds :)

>
> > All errors except timeout are important.
>
> changing the way this timeout works is too difficult, but you could remove
> the piece of code that starts waiting for smsc answer
>
> for the nk6510 driver that you are using this would be (untested):
>
> --- common/phones/nk6510.c.orig 2007-05-16 22:12:29.000000000 +0200
> +++ common/phones/nk6510.c      2007-05-16 22:13:12.000000000 +0200
> @@ -1489,10 +1489,7 @@
>
>         dprintf("Sending SMS...(%d)\n", pos + 9);
>         if (sm_message_send(pos + 9, NK6510_MSG_SMS, req, state)) return
> GN_ERR_NOTREADY; -       do {
> -               error = sm_block_no_retry_timeout(NK6510_MSG_SMS,
> state->config.smsc_timeout, data, state); -       } while
> (!state->config.smsc_timeout && error == GN_ERR_TIMEOUT); -       return
> error;
> +       return GN_ERR_NONE;
>  }
>
>  /*****************/

Daniele, great thanks for the code :D It works perfectly :-))) That's what I 
was looking for ^_^ Now 0 is returned without carrying of timeout :-D


-- 
Krzysztof Śniadoch <krzysiek at securenet.pl>   
http://www.securenet.pl - Information Technology
http://hosting.securenet.pl - Dział Hostingu
[ GPG KeyID: 1F7969B8 ]
fp: 4E13 4F89 0A17 A47F 883B 6855 421B E4E8 1F79 69B