gnokii-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] Fix sending SMSes with certain phones.


From: Pawel Kot
Subject: Re: [patch] Fix sending SMSes with certain phones.
Date: Sat, 8 Jan 2005 14:17:17 +0100 (CET)

On Fri, 7 Jan 2005, David Vrabel wrote:

> Certain phones do not store the leading '+' in phone numbers.  This
> applies to the SMS message centre number and possibly other numbers.
>
> e.g. With a Sony Ericcsson GM47 GSM module
>
> at+csca="+4407802000332"
> OK
> at+csca?
> +CSCA: "4407802000332",145
> OK
>
> char_semi_octet_pack() was unconditionally stripping the leading
> character (on international numbers).  The attached patch causes only
> any leading '+' to be stripped.

Your proposition is:
-       if (type == GN_GSM_NUMBER_International) in_num++; /* Skip '+' */
-       if ((type == GN_GSM_NUMBER_Unknown) && (*in_num == '+')) in_num++; /* 
Optional '+' in Unknown number type */
+       if (*in_num == '+') in_num++; /* skip any leading + */

What about:
        if ((type == GN_GSM_NUMBER_International || type == 
GN_GSM_NUMBER_Unknown)
            && (*in_num == '+')) in_num++; /* skip '+' in international numbers 
*/
?

pkot
-- 
p k o t a t b e z s e n s u d o t p l
http://www.gnokii.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]