Re: [PATCH] Re: Encoding in atgen.c

[Pawel Kot]

On Mon, 28 Jun 2004, Hugo Haas wrote:

Hugo,

> > And really, I'd *much* prefer to have it in ateric.c (instead of
> > encode_everything field).
>
> I had started going this way when I discovered that ateric.c functions
> were for "ericsson" phones and that my T610 was declaring the maker as
> "SONY ERICSSON". Basically, it doesn't use the ateric.c functions, and
> apart from the encoding problem, it seems to work.
>
> So I thought that using drvinst and just do one test in the
> initialization function may be the best way forward.
>
> Other options include making ateric.c functions apply to
> SonyEricssons, maybe with some tests to differentiate with old
> Ericsson phones, or maybe create an atse.c with functions for the
> SonyEricsson.
>
> I think that it's worth noting though that it's just a string encoding
> difference, so the change of behavior is small compared to atgen.c's.

I applied your patch separating it to atsoer.(c|h) files.

After some thinking I think we should have some general at driver function
do_encoding() which would strcpy() for most of the phones and at_encode()
for SonyEricsson. But for now, please test it as it is. And let me know
the result, this was the last change for 0.6.2.

take care,
pkot
-- 
mailto:address@hidden
http://www.gnokii.org/