Re: 3110 SMS data encoding [patch]

[Pawel Kot]

On Fri, 30 May 2003, Osma Suominen wrote:

Hi Osma,

> continuing my 3110 work, here's a patch that fixes SMS data encoding.
> The current code is a huge hack both ways (send & receive). This code
> translates between PDU format in the raw_sms data structure and the
> ASCII (or Latin-1) that the phone expects. It makes for a lot of
> encoding/decoding back and forth but the result works and is clean
> wrt code structure (which the current code isn't).

Cool, thanks for doing this.

I'd like to do it in a bit different way. Currently we have onlu PDU SMS
support in gsm-sms.c. I'd add your sms_data_decode and sms_data_encode
function to gsm-sms.c as sms_asciidata_decode and sms_asciidata_encode.

Then add some distinction (based on the used driver?) in
sms_encode/sms_decode to use the correct header and body encode/decode
function.

In other words, I'd like to have all sms stuff in gsm-sms.c. Does it make
sense for you? Would you implement it? Or would you like me to do it?

pkot
-- 
mailto:address@hidden :: mailto:address@hidden
http://kt.linuxnews.pl/ :: Kernel Traffic po polsku