gnokii-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 3110 robustness fixes (patch)


From: Pawel Kot
Subject: Re: 3110 robustness fixes (patch)
Date: Thu, 6 Mar 2003 22:30:02 +0100 (CET)

On Thu, 6 Mar 2003, Osma Suominen wrote:

> GN_ERR_NOTREADY;
> -     sm_block(0x4d, data, state);
> +     if(sm_block(0x4d, data, state) != GN_ERR_NONE) return

Sometimes I also don't compile my fixes, but that's not a good manner. And
it's amazing how easily you catch such bugs in other code, and not own :-)

>  static int fb3110_message_type_fold(int type)
>  {
>       switch (type) {
> -     case 0x15:

What is 0x15?

pkot
-- 
mailto:address@hidden :: mailto:address@hidden
http://kt.linuxnews.pl/ :: Kernel Traffic po polsku





reply via email to

[Prev in Thread] Current Thread [Next in Thread]