address@hidden: Bug#177435: wrong assumption on char signedness]

[Bradley Marshall]

Hi,

More bug reports.

Thanks,
Brad
----- Forwarded message from Gerhard Tonn <address@hidden> -----

Date: Sun, 19 Jan 2003 16:40:37 +0100
To: address@hidden
From: Gerhard Tonn <address@hidden>
Subject: Bug#177435: wrong assumption on char signedness
Reply-To: Gerhard Tonn <address@hidden>,
        address@hidden
Resent-From: Gerhard Tonn <address@hidden>
Resent-Date: Sun, 19 Jan 2003 15:48:20 GMT
X-Mailer: KMail [version 1.1.99]

Package: gnokii
Version:  0.4.3-7
Severity: important

Hi,
char is per default unsigned on arm, powerpc and s390. There is a warning

smsd.c:203: warning: comparison is always false due to limited range of data 
type

during build of your package that might cause a runtime error. Please check

http://buildd.debian.org/fetch.php?&pkg=gnokii&ver=0.4.3-7&arch=s390&stamp=1042349734&file=log&as=raw

for details.

In your case the variable c should be defined as int. Defining it as char is 
even wrong on i386, since the char 0xff is then interpreted as EOF. On the 
platforms mentioned above the EOF condition is never true, leading to an 
infinite loop.

Thanks,
Gerhard

----- End forwarded message -----

-- 
+=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-+
|Brad Marshall                    |           Plugged In Software|
|Senior Systems Administrator     |     http://www.pisoftware.com|
|mailto:address@hidden   |  GPG Key Id: 47951BD0 / 1024b|
+-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=+
 Fingerprint:  BAE3 4794 E627 2EAF 7EC0  4763 7884 4BE8 4795 1BD0