gnokii-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC] Hard-coded values in xgnokii.c (with patches)


From: Pawel Kot
Subject: Re: [RFC] Hard-coded values in xgnokii.c (with patches)
Date: Fri, 26 Jul 2002 11:20:56 +0200

>>> address@hidden 26 July 2002 11:06:39 >>>
> this time with patches, there were also some hardcoded values in
> xgnokii_logos.c. I also changed 'Familly' into 'Family' :-).
> 
> These are my first ones so please bare with me.

Looks OK except this one:
@@ -221,7 +221,6 @@
        xgnokiiConfig.callerGroups[2] = g_strndup(_("Friends"), 
MAX_CALLER_GROUP_LENGTH);
        xgnokiiConfig.callerGroups[3] = g_strndup(_("Colleagues"), 
MAX_CALLER_GROUP_LENGTH);
        xgnokiiConfig.callerGroups[4] = g_strndup(_("Other"), 
MAX_CALLER_GROUP_LENGTH);
-       xgnokiiConfig.callerGroups[5] = g_strndup(_("No group"), 
MAX_CALLER_GROUP_LENGTH);
 
        if (phoneMonitor.supported & PM_CALLERGROUP) {
                for (i = 0; i < GSM_MAX_CALLER_GROUPS; i++) {

This was intentional I think and should stay. Should be in CVS today.

thanks,
pkot




reply via email to

[Prev in Thread] Current Thread [Next in Thread]