Re: Fix EMS + concat message, cleanup gnokii.c

[Pavel Machek]

Hi!


> > > > That seems ugly to me, and AddUDH does not seem that bad.
> > >
> > > It seems as it add loop in the dependencies.
> >
> > But that loop does not matter, C compiler can survive that.
> 
> But that loop is ugly. And AFAICS cause compile warning.

No compile warning, for sure ;-).

> > > It's hard to call it an evening, but... ;-) I made some changes to CVS.
> > > First of all I decided to separate all Nokia-specific SMS stuff to the
> > > separate functions/files. It will clean up the sources a bit (but make 
> > > code
> > > paths a bit longer). I don't think these changes broke anything yet.
> >
> > Run make test and see for yourself ;-). Tests involving --ocat are expected
> > to be broken as those are only working in my tree.
> 
> Will do. Next changes will break it for sure. I'll remove RawData in SMS
> usage and layouts. I'll try to get back to life 7110 and AT driver. fake
> is based on AT AFAIR.

Yes, fake is very similar to AT, and based on it.

> BTW. Is it OK to remove testing dir in the tarball?

I'd leave it there. It contains pretty nice examples, and people might
want to check that their gnokii appears okay.
                                                                        Pavel
-- 
(about SSSCA) "I don't say this lightly.  However, I really think that the U.S.
no longer is classifiable as a democracy, but rather as a plutocracy." --hpa