Re: Fixing ringtones

[Pawel Kot]

On Fri, 24 May 2002, Pavel Machek wrote:

> Hi!
>
> > >  int GSM_EncodeSMSRingtone(char *message, GSM_Ringtone *ringtone)
> > >  {
> > >   int j = GSM_MAX_8BIT_SMS_LENGTH;
> > > - return GSM_PackRingtone(ringtone, message, &j);
> > > + GSM_PackRingtone(ringtone, message, &j);
> > > + return j;
> > >  }
> >
> > It's ugly. Can we change GSM_PackRingtone singature to:
>
> Agreed its ugly, but it already returns u8 number of notes written,
> plus this is api exported function. Should I still touch it?

Yes. It's used only in 3 places in gnokii, so I think the change will be
harmless.

> Is break mandatory at the end of switch? [Added anyway.]

non-gcc compilers complain about missing break.

pkot
-- 
mailto:address@hidden :: mailto:address@hidden
http://kt.linuxnews.pl/ :: Kernel Traffic po polsku