|
From: | stefasab |
Subject: | Re: [Gnash-dev] [MERGE] Misc fixes to soldumper.cpp |
Date: | Mon, 10 Aug 2009 12:55:06 +0200 |
User-agent: | Mutt/1.5.18 (2008-05-17) |
On date Monday 2009-08-10 11:37:52 +0200, Benjamin Wolsey gnashed: > Am Montag, den 10.08.2009, 11:27 +0200 schrieb stefasab: > > On date Saturday 2009-08-08 11:23:31 +0200, stefasab gnashed: > > > Hi all, > > > > > > I'm doing as an exercise to get more used both to bazaar and also with > > > the development model followed here. > > > > > > Unfortunately looks like bazaar doesn't support to send patches from a > > > branch in a format easily reviewable (a la git --format-patch), please > > > say which is the best way to contribute changes to the project. > > > > Ping? > > > > Email bzr diff? bzr send also exists, but I've never used it. No, unfortunately bzr send (which I used previously) only produces a patch comprehensive of all changes, rather than one patch per commit. I found this relevant feature request: https://bugs.launchpad.net/bzr/+bug/227340 Without this, is *so* much easier for me to use a quilt stack of patches rather than do bzr branch and commit and bzr diff. In attachment the patches issued with bzr diff. Summary: * 0001-soldumper-avoid-usage-for-ref.patch Avoids an ugly forward declaration. * 0002-soldumper-make-usage-use-ostream.patch Extend usage(), so that it takes as parameter an ostream where to put output. * 0003-soldumper-usage-do-not-exit.patch Do not exit explicitly from usage(), since the application may return a different error code depending on the context. * 0004-soldumper-h-print-on-cout.patch soldumper -h should print on cout, as the output of the tool, if not an error, is supposed to be printed there, so the user can do e.g.: soldumper -h | grep foo * 0005-soldumper-exit-1-in-case-of-invalid-syntax.patch A tool should return a non-0 exit code in case of error. Regards.
0001-soldumper-avoid-usage-for-ref.patch
Description: Text Data
0002-soldumper-make-usage-use-ostream.patch
Description: Text Data
0003-soldumper-usage-do-not-exit.patch
Description: Text Data
0004-soldumper-h-print-on-cout.patch
Description: Text Data
0005-soldumper-exit-1-in-case-of-invalid-syntax.patch
Description: Text Data
[Prev in Thread] | Current Thread | [Next in Thread] |