[Gnash-commit] [bug #50462] Gnash shows weird version information when built from detached-HEAD Git repository

[Nutchanon Wetchasit]

Follow-up Comment #4, bug #50462 (project gnash):

Patch included, see below.

These patches use a combination of `git symbolic-ref -q HEAD` and `basename`
to determine current branch. All of them do the same thing, but use a
different placeholder branch nickname when current branch cannot be
determined; only one can be chosen for inclusion in mainline.

Choice 1. Use "none" when current branch cannot be determined:
0001_use-git-symbolicref-for-revno-branch.patch (file #39917)

Gnash 0.8.11dev (none-22387-144e082)

Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Free
Software Foundation, Inc.
Gnash comes with NO WARRANTY, to the extent permitted by law.
You may redistribute copies of Gnash under the terms of the GNU General
Public License.  For more information, see the file named COPYING.

Build options 
   Renderers: agg cairo opengl
   Hardware Acceleration: RawFB
   GUI: GTK
   Media handlers: ffmpeg gst 
   Configured with: --enable-media=ffmpeg,gst
--enable-renderer=agg,cairo,opengl --enable-gui=gtk,qt4,sdl,fb,dump
--enable-docbook
   CXXFLAGS: -g -O2 -std=c++11          -W     -Wall     -Wcast-qual    
-Wpointer-arith     -Wreturn-type     -Wnon-virtual-dtor     -Wunused     
-fvisibility-inlines-hidden -fvisibility=hidden -fpie -fPIE -Wformat
-Werror=format-security -fstack-protector --param ssp-buffer-size=4

(Screenshot of About Gnash dialog: file #39918)

Choice 2. Use "unknown" when current branch cannot be determined:
0001_use-git-symbolicref-for-revno-branch-unknown-placeholder.patch (file
#39919)

Gnash 0.8.11dev (unknown-22387-144e082)

Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Free
Software Foundation, Inc.
Gnash comes with NO WARRANTY, to the extent permitted by law.
You may redistribute copies of Gnash under the terms of the GNU General
Public License.  For more information, see the file named COPYING.

Build options 
   Renderers: agg cairo opengl
   Hardware Acceleration: RawFB
   GUI: GTK
   Media handlers: ffmpeg gst 
   Configured with: --enable-media=ffmpeg,gst
--enable-renderer=agg,cairo,opengl --enable-gui=gtk,qt4,sdl,fb,dump
--enable-docbook
   CXXFLAGS: -g -O2 -std=c++11          -W     -Wall     -Wcast-qual    
-Wpointer-arith     -Wreturn-type     -Wnon-virtual-dtor     -Wunused     
-fvisibility-inlines-hidden -fvisibility=hidden -fpie -fPIE -Wformat
-Werror=format-security -fstack-protector --param ssp-buffer-size=4

(Screenshot of About Gnash dialog: file #39920)

Choice 3. Use pre-written version from configure.ac's `AC_INIT`
<https://git.savannah.gnu.org/cgit/gnash.git/tree/configure.ac?id=144e0827072b746b2bedebe39ca8a7e0fb43a455#n20>
when current branch cannot be determined:
0001_use-git-symbolicref-for-revno-branch-version-placeholder.patch (file
#39921)

Gnash 0.8.11dev (0.8.11dev-22387-144e082)

Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Free
Software Foundation, Inc.
Gnash comes with NO WARRANTY, to the extent permitted by law.
You may redistribute copies of Gnash under the terms of the GNU General
Public License.  For more information, see the file named COPYING.

Build options 
   Renderers: agg cairo opengl
   Hardware Acceleration: RawFB
   GUI: GTK
   Media handlers: ffmpeg gst 
   Configured with: --enable-media=ffmpeg,gst
--enable-renderer=agg,cairo,opengl --enable-gui=gtk,qt4,sdl,fb,dump
--enable-docbook
   CXXFLAGS: -g -O2 -std=c++11          -W     -Wall     -Wcast-qual    
-Wpointer-arith     -Wreturn-type     -Wnon-virtual-dtor     -Wunused     
-fvisibility-inlines-hidden -fvisibility=hidden -fpie -fPIE -Wformat
-Werror=format-security -fstack-protector --param ssp-buffer-size=4

(Screenshot of About Gnash dialog: file #39922)

Portability notes:

* A use of `basename` shouldn't be problem since `configure` is already using
it.
* `git symbolic-ref -q HEAD` works in expected manner at least in Git 1.5.6.5,
1.7.10.4, and 2.11.1.

Gnash: 0.8.11dev (patched against git 144e082 22-Feb-2017)
Git: 1:1.7.10.4-1+wheezy1 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?50462>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/