[Gnash-commit] [bug #50462] Gnash shows weird version information when built from detached-HEAD Git repository

[Nutchanon Wetchasit]

Follow-up Comment #1, bug #50462 (project gnash):

This seems to boil down to how Gnash build script extracts branch information
from the repository...

Makefile.am:161
<https://git.savannah.gnu.org/cgit/gnash.git/tree/Makefile.am?id=144e0827072b746b2bedebe39ca8a7e0fb43a455#n161>:

nick="`cd $(top_srcdir) ; $(GIT) branch | grep '^\*' | cut -d ' ' -f 2`"; \


Running `git branch` in the repository after `git checkout 144e082` shows:

$ git branch
* (no branch)
  master
$


Since what branch retrieval command did is finding line beginning with "*" and
use its 2nd column (separated by space). So "(no branch)" became "(no"
displayed in the version string:

$ git branch | grep '^\*' | cut -d ' ' -f 2
(no
$
-verbatim+

If a more modern version of git (e.g. 2.11.1) is used, output would be even
more weird:

$ git --version
git version 2.11.1
$ git branch
* (HEAD detached at 144e08270)
  master
$ git branch | grep '^\*' | cut -d ' ' -f 2
(HEAD
$


Maybe a fix would involve changing the source of branch information from
porcelain `git branch` (which is prone to format changes) to something
low-level like `git symbolic-ref` (which is recommended for scripting).

Gnash: 0.8.11dev (git 144e082 22-Feb-2017)
Git: 1:1.7.10.4-1+wheezy1 (debian)
Git: 2.11.1 (source)
System: Debian GNU/Linux 7.0 Wheezy i386


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?50462>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/