gnash-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnash-commit] [patch #8935] Patch for providing `_global` as a fallback


From: Nutchanon Wetchasit
Subject: [Gnash-commit] [patch #8935] Patch for providing `_global` as a fallback instance in `Function.call()` and `Function.apply()`
Date: Thu, 10 Mar 2016 11:03:45 +0000
User-agent: Mozilla/5.0 (X11; Linux i686; rv:25.8) Gecko/20151123 Firefox/31.9 PaleMoon/25.8.1

Follow-up Comment #2, patch #8935 (project gnash):

Patch 2 of 2:
See the attached
`0002_add-function-call-global-fallback-instance-tests.patch`.

This patch adds following automated checks on `Function.call()` and
`Function.apply()` to ActionScript section of Gnash testsuite:

* Function.apply() tests:
** `this` inside function called with `Function.apply()` should be strictly
equal to `_global`.
** Property set to `this` inside function called with `Function.apply()`
should end up in `_global` object.
** `this` inside function called with `Function.apply(undefined)` should be
strictly equal to `_global`.
** Property set to `this` inside function called with
`Function.apply(undefined)` should end up in `_global` object.
** `this` inside function called with `Function.apply(null)` should be
strictly equal to `_global`.
** Property set to `this` inside function called with `Function.apply(null)`
should end up in `_global` object.
* Function.call() tests:
** `this` inside function called with `Function.call()` should be strictly
equal to `_global`.
** Property set to `this` inside function called with `Function.call()` should
end up in `_global` object.
** `this` inside function called with `Function.call(undefined)` should be
strictly equal to `_global`.
** Property set to `this` inside function called with
`Function.call(undefined)` should end up in `_global` object.
** `this` inside function called with `Function.call(null)` should be strictly
equal to `_global`.
** Property set to `this` inside function called with `Function.call(null)`
should end up in `_global` object.

Might need a review, for the same reason as second half
<https://savannah.gnu.org/patch/?8933#comment3> of patch #8933.

Gnash: 0.8.11dev (patched against git a72afa5 9-Mar-2016)
System: Debian GNU/Linux 7.0 Wheezy i386


(file #36594)
    _______________________________________________________

Additional Item Attachment:

File name: 0002_add-function-call-global-fallback-instance-tests.patch Size:4
KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8935>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]