[Gnash-commit] [patch #8751] Patch to fix AudioDecoderSimple's code comment regarding 8-bit PCM audio codec

[Nutchanon Wetchasit]

URL:
  <http://savannah.gnu.org/patch/?8751>

                 Summary: Patch to fix AudioDecoderSimple's code comment
regarding 8-bit PCM audio codec
                 Project: Gnash - The GNU Flash player
            Submitted by: nachanon
            Submitted on: Wed 23 Sep 2015 05:44:59 PM ICT
                Category: sound
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

This is a follow-up to patch #8747.

Gnash's AudioDecoderSimple has a working 8-bit PCM sound decoder
implementation.
But inside the class, there are some
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libmedia/AudioDecoderSimple.cpp?id=516a6cae2301c582b54d7f00188c8e22c5d76c1b#n390>
wrong
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libmedia/AudioDecoderSimple.cpp?id=516a6cae2301c582b54d7f00188c8e22c5d76c1b#n401>
code comments which falsely stated
that Flash's 8-bit PCM audio was a signed PCM format. (It is _unsigned_ PCM,
according to what the code implements
<http://git.savannah.gnu.org/cgit/gnash.git/tree/libmedia/AudioDecoderSimple.cpp?id=516a6cae2301c582b54d7f00188c8e22c5d76c1b#n257>,
and a test <https://savannah.gnu.org/bugs/?45722#comment26>)

This patch fixes the wrong comments, so it won't cause any further confusion.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed 23 Sep 2015 05:44:59 PM ICT  Name:
0009_fix-audiodecoder-simple-pcm-u8-code-comment.patch  Size: 1kB   By:
nachanon
Patch for fixing 8-bit PCM audio comment in AudioDecoderSimple
<http://savannah.gnu.org/patch/download.php?file_id=34961>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?8751>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/