Re: [Gnash-commit] [patch #8086] RTMP netStream patch

[George Thomas]

On Wed, Jul 31, 2013 at 6:03 PM, Sandro Santilli <address@hidden> wrote:
> On Wed, Jul 31, 2013 at 11:52:16AM +0000, George Thomas wrote:
>> Follow-up Comment #6, patch #8086 (project gnash):
>>
>> Ran the regressing with the source checked out today. Could not find any
>> regressions when tested with and without rtmp2.patch
>>
>> As regressions are absent is this good enough to go in or what work would 
>> have
>> to be done to ensure that the patch is better?
>
> You should add a test showing that the patch is needed.
> The test would fail without the patch and succeed with it.
> The test should be self-contained, so that it is easier for
> anyone to verify its expectances are correct by running it
> with the proprietary player.
>

What I used was red5 running locally to test it. Then used
"make oflaDemo.swf" to make the swf and then ran with gnash.

I found an option --enable-red5-testing=<host>.
Should the tests be written in such a way that they become
active with the option ?

>> I was getting these failures in both cases.
>>
> ...
>> Unexpected failures follow:
>>  --=[ testsuite/actionscript.all ]=--
>> FAIL: astests-v6-Runner: no onSoundComplete arrived after 3 seconds
>> FAIL: astests-v6-Runner: Tests run 107 (expected 112) [
>> [../../../gnash/testsuite/actionscript.all/Sound.as:31]]
>> FAIL: astests-v7-Runner: no onSoundComplete arrived after 3 seconds
>> FAIL: astests-v7-Runner: Tests run 107 (expected 112) [
>> [../../../gnash/testsuite/actionscript.all/Sound.as:31]]
>> FAIL: astests-v8-Runner: no onSoundComplete arrived after 3 seconds
>> FAIL: astests-v8-Runner: Tests run 107 (expected 112) [
>> [../../../gnash/testsuite/actionscript.all/Sound.as:31]]
>>
>> Could not understand why these were happening.
>
> I believe these are due to using GST media handler rather than FFMPEG, can
> you confirm ?
>
> --strk;

I had the gst media handler
gnash --version gave output

Build options
   Renderers: agg cairo
   Hardware Acceleration: RawFB
   GUI: GTK
   Media handlers: gst
   Configured with: --enable-docbook
   CXXFLAGS: -g -O2          -W     -Wall     -Wcast-qual
-Wpointer-arith     -Wreturn-type     -Wnon-virtual-dtor     -Wunused
    -fvisibility-inlines-hidden -fPIE -fstack-protector --param
ssp-buffer-size=4 -Wformat -Werror=format-security