[Gnash-commit] gnash ChangeLog server/as_object.h

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  07/07/18 00:07:31

Modified files:
        .              : ChangeLog 
        server         : as_object.h 

Log message:
                * server/as_object.h: fix comments about case sensitiveness of
                  get_member* and set_member*.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.3748&r2=1.3749
http://cvs.savannah.gnu.org/viewcvs/gnash/server/as_object.h?cvsroot=gnash&r1=1.60&r2=1.61

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.3748
retrieving revision 1.3749
diff -u -b -r1.3748 -r1.3749
--- ChangeLog   17 Jul 2007 23:16:06 -0000      1.3748
+++ ChangeLog   18 Jul 2007 00:07:30 -0000      1.3749
@@ -1,5 +1,7 @@
 2007-07-17 Sandro Santilli <address@hidden>
 
+       * server/as_object.h: fix comments about case sensitiveness of
+         get_member* and set_member*.
        * gui/Makefile.am: add gtk_cairo_create.h in GTK_CAIRO_SRCS.
 
 2007-07-18 Markus Gothe <address@hidden>

Index: server/as_object.h
===================================================================
RCS file: /sources/gnash/gnash/server/as_object.h,v
retrieving revision 1.60
retrieving revision 1.61
diff -u -b -r1.60 -r1.61
--- server/as_object.h  1 Jul 2007 10:54:20 -0000       1.60
+++ server/as_object.h  18 Jul 2007 00:07:31 -0000      1.61
@@ -166,6 +166,14 @@
        /// NOTE: This might change in the near future trough use of
        ///       getter/setter properties instead..
        ///
+       /// @param name
+       ///     Name of the property. Must be all lowercase
+       ///     if the current VM is initialized for a  target
+       ///     up to SWF6.
+       ///
+       /// @param val
+       ///     Value to assign to the named property.
+       ///
        virtual void set_member(const std::string& name, const as_value& val)
        {
                return set_member_default(name, val);
@@ -243,14 +251,24 @@
        /// The default behaviour is to call set_member_default,
        /// but this function is kept virtual to allow special
        /// handling of property fetching in derivate class.
-       /// NOTE: This might change in the near future trough use of
-       ///       getter/setter properties instead..
        ///
        /// NOTE that this method is non-const becase a property
        ///      could also be a getter/setter and we can't promise
        ///      that the 'getter' won't change this object trough
        ///      use of the 'this' reference.
        ///
+       /// @param name
+       ///     Name of the property. Must be all lowercase
+       ///     if the current VM is initialized for a  target
+       ///     up to SWF6.
+       ///
+       /// @param val
+       ///     Variable to assign an existing value to.
+       ///     Will be untouched if no property with the given name
+       ///     was found.
+       ///
+       /// @return true of the named property was found, false otherwise.
+       ///
        virtual bool get_member(const std::string& name, as_value* val)
        {
                return get_member_default(name, val);
@@ -292,10 +310,10 @@
 
        /// Set member flags (probably used by ASSetPropFlags)
        //
-       /// @parame name
-       ///     Name of the property.
-       ///     Case insensitive up to SWF6,
-       ///     case *sensitive* from SWF7 up.
+       /// @param name
+       ///     Name of the property. Must be all lowercase
+       ///     if the current VM is initialized for a  target
+       ///     up to SWF6.
        ///
        /// @param setTrue
        ///     the set of flags to set
@@ -453,11 +471,9 @@
        ///      use of the 'this' reference.
        ///
        /// @param name
-       ///     Name of the property.
-       ///     Case insensitive up to SWF6,
-       ///     case *sensitive* from SWF7 up.
-       ///     TODO: be *always* case-sensitive, and delegate
-       ///           convertion to lowercase to callers
+       ///     Name of the property. Must be all lowercase
+       ///     if the current VM is initialized for a  target
+       ///     up to SWF6.
        ///
        /// @param val
        ///     The as_value to store a found variable's value in.
@@ -472,10 +488,13 @@
         /// The derived class should not override this method,
         /// but instead implement its own gettersetter properties.
        ///
-       /// @parame name
-       ///     Name of the property.
-       ///     Case insensitive up to SWF6,
-       ///     case *sensitive* from SWF7 up.
+       /// @param name
+       ///     Name of the property. Must be all lowercase
+       ///     if the current VM is initialized for a  target
+       ///     up to SWF6.
+       ///
+       /// @param val
+       ///     Value to assign to the named property.
        ///
        void set_member_default(const std::string& name, const as_value& val);