[Gnash-commit] gnash ChangeLog testsuite/actionscript.all/Movi...

[Sandro Santilli]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Sandro Santilli <strk>  07/07/13 20:23:28

Modified files:
        .              : ChangeLog 
        testsuite/actionscript.all: MovieClip.as TextField.as 

Log message:
                * testsuite/actionscript.all/MovieClip.as: add notes about 
where we
                  have been reported differences between proprietary player 
versions;
                  fix check for return code of createTextField for SWF8.
                * testsuite/actionscript.all/TextField.as:
                  fix check for return code of createTextField for SWF8;
                  fix expected failures.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.3737&r2=1.3738
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/actionscript.all/MovieClip.as?cvsroot=gnash&r1=1.71&r2=1.72
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/actionscript.all/TextField.as?cvsroot=gnash&r1=1.4&r2=1.5

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.3737
retrieving revision 1.3738
diff -u -b -r1.3737 -r1.3738
--- ChangeLog   13 Jul 2007 20:04:15 -0000      1.3737
+++ ChangeLog   13 Jul 2007 20:23:27 -0000      1.3738
@@ -1,5 +1,14 @@
 2007-07-13 Sandro Santilli <address@hidden>
 
+       * testsuite/actionscript.all/MovieClip.as: add notes about where we
+         have been reported differences between proprietary player versions; 
+         fix check for return code of createTextField for SWF8.
+       * testsuite/actionscript.all/TextField.as:
+         fix check for return code of createTextField for SWF8;
+         fix expected failures.
+
+2007-07-13 Sandro Santilli <address@hidden>
+
        * testsuite/actionscript.all/CustomActions.as: add a note about why
          no tests are run.
        * server/asobj/Mouse.cpp: fix case of addListener and removeListener

Index: testsuite/actionscript.all/MovieClip.as
===================================================================
RCS file: /sources/gnash/gnash/testsuite/actionscript.all/MovieClip.as,v
retrieving revision 1.71
retrieving revision 1.72
diff -u -b -r1.71 -r1.72
--- testsuite/actionscript.all/MovieClip.as     1 Jul 2007 10:54:39 -0000       
1.71
+++ testsuite/actionscript.all/MovieClip.as     13 Jul 2007 20:23:28 -0000      
1.72
@@ -22,7 +22,7 @@
 // compile this test case with Ming makeswf, and then
 // execute it like this gnash -1 -r 0 -v out.swf
 
-rcsid="$Id: MovieClip.as,v 1.71 2007/07/01 10:54:39 bjacques Exp $";
+rcsid="$Id: MovieClip.as,v 1.72 2007/07/13 20:23:28 strk Exp $";
 
 #include "check.as"
 
@@ -211,14 +211,16 @@
 check_equals(mc._alpha, 100);
 check(mc._currentframe != undefined);
 
-#if OUTPUT_VERSION > 5
 check_equals(mc._droptarget, "");
-check_equals(typeof(mc._droptarget), "string");
-#else
-//WARNING: we have player 9 succeeds on this, and also player 7 fails on this
-// don't know which one to trust.
-xcheck_equals(mc._droptarget, "");
-#endif
+if (typeof(mc._droptarget) != "string")
+{
+       fail("typeof(mc._droptarget) = "+typeof(mc._droptarget)+" (expected 
'string') ["+__FILE__+":"+__LINE__+"]");
+       note(" WARNING: some players have been reported to evaluate _droptarget 
to undefined, rather then the empty string. Reguardless of SWF target.");
+}
+else
+{
+       pass("typeof(mc._droptarget) = "+typeof(mc._droptarget)+" 
["+__FILE__+":"+__LINE__+"]");
+}
 
 check(mc._focusrect != undefined);
 check(mc._framesloaded != undefined);
@@ -487,8 +489,16 @@
 #if OUTPUT_VERSION > 5
 check_equals(a, "changed");
 #else
-// this check fails with Adobe Flash Player 9
-check_equals(a, undefined);
+if ( a == undefined )
+{
+       pass("<empty>._name (trough getProperty(13)) returns undefined 
["+__FILE__+":"+__LINE__+"]");
+}
+else
+{
+       // this check fails with Adobe Flash Player 9
+       fail("<empty>._name (trough getProperty(13)) returns "+a+" (expected 
undefined) ["+__FILE__+":"+__LINE__+"]");
+       note("Some version of Adobe Flash Player 9 are reported to have this 
bug");
+}
 #endif
 
 asm {
@@ -510,8 +520,16 @@
 #if OUTPUT_VERSION > 5
 check_equals(a, "changed");
 #else
-// this check fails with Adobe Flash Player 9
-check_equals(a, undefined);
+if ( a == undefined )
+{
+       pass("_root._name (trough getProperty(13)) returns undefined 
["+__FILE__+":"+__LINE__+"]");
+}
+else
+{
+       // this check fails with Adobe Flash Player 9
+       fail("_root._name (trough getProperty(13)) returns "+a+" (expected 
undefined) ["+__FILE__+":"+__LINE__+"]");
+       note("Some version of Adobe Flash Player 9 are reported to have this 
bug");
+}
 #endif
 
 asm {
@@ -530,7 +548,13 @@
 //------------------------------------------------
 
 t = createTextField("textfieldTest", 3, 0, 100, 100, 100);
+#if OUTPUT_VERSION < 8
 check_equals(typeof(t), 'undefined');
+#else
+xcheck_equals(typeof(t), 'object');
+xcheck_equals(t, _root.textfieldTest);
+#endif // OUTPUT_VERSION >= 8
+
 #if OUTPUT_VERSION > 5
 check_equals(typeof(textfieldTest), 'object');
 check(textfieldTest instanceof TextField);

Index: testsuite/actionscript.all/TextField.as
===================================================================
RCS file: /sources/gnash/gnash/testsuite/actionscript.all/TextField.as,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -b -r1.4 -r1.5
--- testsuite/actionscript.all/TextField.as     13 Jul 2007 19:13:47 -0000      
1.4
+++ testsuite/actionscript.all/TextField.as     13 Jul 2007 20:23:28 -0000      
1.5
@@ -20,7 +20,7 @@
 // compile this test case with Ming makeswf, and then
 // execute it like this gnash -1 -r 0 -v out.swf
 
-rcsid="$Id: TextField.as,v 1.4 2007/07/13 19:13:47 strk Exp $";
+rcsid="$Id: TextField.as,v 1.5 2007/07/13 20:23:28 strk Exp $";
 
 #include "check.as"
 
@@ -98,7 +98,12 @@
 //--------------------------------------------------
 
 ret = createTextField("tf", 99, 10, 10, 500, 500);
-check_equals(typeof(ref), 'undefined');
+#if OUTPUT_VERSION < 8
+check_equals(typeof(ret), 'undefined');
+#else
+xcheck_equals(typeof(ret), 'object');
+xcheck_equals(ret, _root.tf);
+#endif
 
 check_equals(typeof(tf), 'object');
 
@@ -520,7 +525,7 @@
 tf._xscale = 200;
 note("textWidth: _xscale=100: "+currTextWidth+"; _xscale=200: "+tf.textWidth);
 // check_equals(tf.textWidth, currTextWidth*2); // not clear what does 
textWidth depend on
-check_equals(tf._width, currWidth*2);
+xcheck_equals(tf._width, currWidth*2);
 tf._xscale = 100;
 
 // Check TextField._y 
@@ -554,7 +559,7 @@
 tf._yscale = 200;
 note("textHeight: _yscale=100: "+currTextHeight+"; _yscale=200: 
"+tf.textHeight);
 // check_equals(tf.textHeight, currTextHeight*2); // not clear what does 
textHeight depend on
-check_equals(tf._height, currHeight*2);
+xcheck_equals(tf._height, currHeight*2);
 tf._yscale = 100;