[Gnash-commit] gnash ChangeLog testsuite/misc-ming.all/key_eve...

[Zou Lunkai]

CVSROOT:        /sources/gnash
Module name:    gnash
Changes by:     Zou Lunkai <zoulunkai>  07/07/11 06:43:08

Modified files:
        .              : ChangeLog 
        testsuite/misc-ming.all: key_event_test4.c key_event_test5.c 
                                 key_event_test5runner.cpp 

Log message:
        testcase comments and cleanups.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnash/ChangeLog?cvsroot=gnash&r1=1.3710&r2=1.3711
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/misc-ming.all/key_event_test4.c?cvsroot=gnash&r1=1.2&r2=1.3
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/misc-ming.all/key_event_test5.c?cvsroot=gnash&r1=1.3&r2=1.4
http://cvs.savannah.gnu.org/viewcvs/gnash/testsuite/misc-ming.all/key_event_test5runner.cpp?cvsroot=gnash&r1=1.1&r2=1.2

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/gnash/gnash/ChangeLog,v
retrieving revision 1.3710
retrieving revision 1.3711
diff -u -b -r1.3710 -r1.3711
--- ChangeLog   11 Jul 2007 02:57:59 -0000      1.3710
+++ ChangeLog   11 Jul 2007 06:43:07 -0000      1.3711
@@ -1,3 +1,10 @@
+2007-07-11 Zou Lunkai <address@hidden>
+
+       * testsuite/misc-ming.all/key_event_test4.c, key_event_test5.c: call 
totals()
+         instead of total() to give a final report, the later one is an 
undefined function.
+       * testsuite/misc-ming.all/key_event_test5runner.c: add comments why 
Gnash fails, 
+         it forgets to do the case conversion, a big bug!
+         
 2007-07-10 Sandro Santilli <address@hidden>
 
        * server/: fontlib.h, gnash.h: move fontlib namespace

Index: testsuite/misc-ming.all/key_event_test4.c
===================================================================
RCS file: /sources/gnash/gnash/testsuite/misc-ming.all/key_event_test4.c,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -b -r1.2 -r1.3
--- testsuite/misc-ming.all/key_event_test4.c   1 Jul 2007 10:54:55 -0000       
1.2
+++ testsuite/misc-ming.all/key_event_test4.c   11 Jul 2007 06:43:08 -0000      
1.3
@@ -71,7 +71,7 @@
                   " { "
                   "   check_equals(thisPtr, _level0.clip); "   
                   " } "
-                  " total();  stop(); ");
+                  " totals();  stop(); ");
   SWFMovie_nextFrame(mo);  
   
   //Output movie

Index: testsuite/misc-ming.all/key_event_test5.c
===================================================================
RCS file: /sources/gnash/gnash/testsuite/misc-ming.all/key_event_test5.c,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -b -r1.3 -r1.4
--- testsuite/misc-ming.all/key_event_test5.c   10 Jul 2007 11:49:17 -0000      
1.3
+++ testsuite/misc-ming.all/key_event_test5.c   11 Jul 2007 06:43:08 -0000      
1.4
@@ -110,7 +110,7 @@
   check_equals(mo, "typeof(obj)", "'undefined'"); 
   check_equals(mo, "typeof(objRef)", "'undefined'"); 
   
-  add_actions(mo, "stop(); total();");
+  add_actions(mo, "stop(); totals();");
   SWFMovie_nextFrame(mo);  
   
   //Output movie

Index: testsuite/misc-ming.all/key_event_test5runner.cpp
===================================================================
RCS file: 
/sources/gnash/gnash/testsuite/misc-ming.all/key_event_test5runner.cpp,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -b -r1.1 -r1.2
--- testsuite/misc-ming.all/key_event_test5runner.cpp   10 Jul 2007 14:43:20 
-0000      1.1
+++ testsuite/misc-ming.all/key_event_test5runner.cpp   11 Jul 2007 06:43:08 
-0000      1.2
@@ -50,7 +50,8 @@
   tester.advance();
   
   as_value tmp;
-  // ???, can not find 'hasKeyPressed'?
+  // Gnash fails because it forget to do the case conversion.
+  // A big old bug!
   xcheck(root->get_member("hasKeyPressed", &tmp));
   check_equals(tmp.to_number(), 0.0);
   
@@ -66,7 +67,8 @@
   }
   check_equals(root->get_current_frame(), 8);
   
-  // ???, can not find 'hasKeyPressed'?
+  // Gnash fails because it forget to do the case conversion.
+  // A big old bug!
   xcheck(root->get_member("hasKeyPressed", &tmp));
   xcheck_equals(tmp.to_number(), 1.0);