[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gnash-commit] gnash ChangeLog server/as_object.h
From: |
Bastiaan Jacques |
Subject: |
Re: [Gnash-commit] gnash ChangeLog server/as_object.h |
Date: |
Mon, 08 Jan 2007 10:02:38 +0100 |
On Sat, 2006-12-30 at 23:34 +0000, Sandro Santilli wrote:
> Log message:
> * server/as_object.h (get_numeric_value): return 0 if
> get_text_value() returns NULL.
> Index: server/as_object.h
> ===================================================================
> RCS file: /sources/gnash/gnash/server/as_object.h,v
> retrieving revision 1.27
> retrieving revision 1.28
> diff -u -b -r1.27 -r1.28
> --- server/as_object.h 12 Dec 2006 16:58:31 -0000 1.27
> +++ server/as_object.h 30 Dec 2006 23:34:09 -0000 1.28
> @@ -126,7 +126,9 @@
> /// to a number, override for a more performant implementation
> ///
> virtual double get_numeric_value() const {
> - return atof(get_text_value());
> + const char* txt = get_text_value();
> + if ( txt ) return atof(get_text_value());
> + else return 0;
> }
Nit: you don't need the "else" here; you can just return.
Bastiaan
- Re: [Gnash-commit] gnash ChangeLog server/as_object.h,
Bastiaan Jacques <=