Re: [Gm2] Small omission in Glibc.c

[Gaius Mulley]

Gaius Mulley <address@hidden> writes:

> Ernst Bokkelkamp <address@hidden> writes:
>
>> I found a small omission in Glibc.c that causes a problem under Raspbian
>> Jessie:
>>
>> ---
>> ./GM2_520/gcc-5.2.0+gm2-git-latest/gm2/gcc-versionno/gcc/gm2/mc-boot-ch/Glib
>> c.c     2017-03-21 21:34:42.000000000 +0100
>> +++
>> ./GM2_520_fixed/gcc-5.2.0+gm2-git-latest/gm2/gcc-versionno/gcc/gm2/mc-boot-c
>> h/Glibc.c       2017-03-27 16:49:36.980048646 +0200
>> @@ -22,7 +22,7 @@
>>
>>  int libc_close (int fd)
>>  {
>> -  close (fd);
>> +  return close (fd);
>>  }
>>
>>  int libc_exit (int code)
>>
>> With the fix I obtained the following results:
>>
>> Linux debian 3.16.0-4-686-pae #1 SMP Debian 3.16.36-1+deb8u2 (2016-10-19)
>> i686 GNU/Linux
>> # of expected passes            10340
>> # of unexpected failures        30
>> # of unresolved testcases       6
>>
>> Linux debian3 3.16.0-4-amd64 #1 SMP Debian 3.16.39-1 (2016-12-30) x86_64
>> GNU/Linux
>> # of expected passes            10352
>> # of unexpected failures        18
>> # of unresolved testcases       6
>>
>> Linux raspi3p3 4.4.50+ #970 Mon Feb 20 19:12:50 GMT 2017 armv6l GNU/Linux
>> # of expected passes            10340
>> # of unexpected failures        30
>> # of unresolved testcases       6
>>
>> Regards
>> Ernst
>
> Hi Ernst,
>
> many thanks for the bug report - will apply the fix.  I've also moved
> some of the test cases around, which should result in fewer failures.
> [Which will be git pushed today].  I wonder if you can email me the
> gm2.sum file found in: build-5.2.0/gcc/testsuite/gm2.sum, if so then
> I'll add it to the regression test table
>
> regards,
> Gaius

Hi,

just to followup, now committed and pushed,

thanks again,
Gaius