glibc-bsd-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Glibc-bsd-hackers] Re: [PATCH] GNU/k*BSD fixes [w/ChangeLog]


From: Mark Kettenis
Subject: [Glibc-bsd-hackers] Re: [PATCH] GNU/k*BSD fixes [w/ChangeLog]
Date: Mon, 9 Aug 2004 08:59:20 +0200 (CEST)

   Date: Sat, 7 Aug 2004 04:20:15 +0200
   From: Robert Millan <address@hidden>

   Hi!

   Please could someone apply the attached patch?

   Entry for gdb/ChangeLog follows:

   2004-08-07  Robert Millan  <address@hidden>

           * configure.host: Match kfreebsd*-gnu and knetbsd*-gnu.
           * configure.tgt: Match kfreebsd*-gnu and knetbsd*-gnu.
           * bsd-kvm.c: Check for nlist.h before including it.
           * i386bsd-nat.c: Match kernel of FreeBSD also with
           __FreeBSD_kernel__ and __FreeBSD_kernel_version macros.

Yuck, the #ifdef mess in i386bsd-nat.c gets ugly.  I think it should
be simplified.  You're probably changing it to avoid the warning about
the offsets in `struct sigcontext'.  If I just drop the support for
ancient BSD (which isn't used anyway) we can avoid that.  You won't
get the extra check on GNU/kFreeBSD then, but as long as enough people
use GDB on normal FreeBSD/i386, this doesn't really matter.

Considering the changes to bsd-kvm.c.  We shouldn't include config.h
directly.  In GDB "defs.h" does that for us.  I assume that GNU/k*BSD
still has libkvm.  Why doesn't it have <nlist.h>?  If not, then where
does it get its `struct nlist' from?

Mark




reply via email to

[Prev in Thread] Current Thread [Next in Thread]