Re: [Getfem-users] Bug related to element faces referred both as short_type and size_type

[Konstantinos Poulios]

Done in commit 4731. If anyone encounters any issues, let me know and I will help to solve them. Since the commit touches many files, some effort will be required for rebasing uncommitted work on top of the current code. For avoiding bugs introduced due to poor rebasing, I would recommend a visual diff tool like http://meldmerge.org/ .

Best regards

Kostas

On Mon, Jul 21, 2014 at 10:42 PM, Yves Renard <address@hidden> wrote:

Dear Kostas,

You are right of course. This have to be standardized.

Best regards,

Yves.

----- Original Message -----
From: "Konstantinos Poulios" <address@hidden>
To: address@hidden
Sent: Monday, July 21, 2014 7:56:56 PM
Subject: Re: [Getfem-users] Bug related to element faces referred both as       short_type and size_type






After looking into that, it is a bit worse than I thought. In different places of getfem, short_type, size_type and even dim_type are used for referring to element faces.

Now, I have a patch tidying this up, which makes all occurrences of faces of type short_type but it is quite extensive and it obviously changes the getfem API quite a bit. Maybe it is a good opportunity now that 4.3 release is out to commit these changes and fix any issues that may arise until the release of version 5.


Any opinions?


Best regards
Kostas




On Mon, Jul 21, 2014 at 2:14 PM, Konstantinos Poulios < address@hidden > wrote:








Hi,

I have just noticed that in fem_interpolation_context, element faces are referred as size_type, while in mesh_region_visitor, short_type is used.

One consequence of this is that the fem_interpolation_context::is_on_face() method seems not to work at the moment.

I have the impression that short_type is used in most cases for referring to element faces in getfem. Should I fix fem_interpolation_context making it to use the short_type instead?

Best regards
Kostas

_______________________________________________
Getfem-users mailing list
address@hidden
https://mail.gna.org/listinfo/getfem-users