getfem-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Getfem-commits] r4831 - /trunk/getfem/src/gmm/gmm_dense_matrix_function


From: logari81
Subject: [Getfem-commits] r4831 - /trunk/getfem/src/gmm/gmm_dense_matrix_functions.h
Date: Tue, 09 Dec 2014 22:14:25 -0000

Author: logari81
Date: Tue Dec  9 23:14:24 2014
New Revision: 4831

URL: http://svn.gna.org/viewcvs/getfem?rev=4831&view=rev
Log:
minor improvement in logm function

Modified:
    trunk/getfem/src/gmm/gmm_dense_matrix_functions.h

Modified: trunk/getfem/src/gmm/gmm_dense_matrix_functions.h
URL: 
http://svn.gna.org/viewcvs/getfem/trunk/getfem/src/gmm/gmm_dense_matrix_functions.h?rev=4831&r1=4830&r2=4831&view=diff
==============================================================================
--- trunk/getfem/src/gmm/gmm_dense_matrix_functions.h   (original)
+++ trunk/getfem/src/gmm/gmm_dense_matrix_functions.h   Tue Dec  9 23:14:24 2014
@@ -138,7 +138,7 @@
                 "Matrix logarithm is not defined for non-square matrices");
     for (size_type i=0; i < n-1; ++i)
       if (gmm::abs(S(i+1,i)) > default_tol(T())) {
-        GMM_ASSERT1(false, "An uppper diagonal matrix is expected");
+        GMM_ASSERT1(false, "An upper triangular matrix is expected");
         break;
       }
     for (size_type i=0; i < n-1; ++i)
@@ -266,6 +266,9 @@
       gmm::copy(gmm::real_part(S), gmm::real_part(cS));
       gmm::copy(gmm::real_part(Q), gmm::real_part(cQ));
       block2x2_reduction(cS, cQ, default_tol(R())*R(3));
+      for (size_type j=0; j < n-1; ++j)
+        for (size_type i=j+1; i < n; ++i)
+          cS(i,j) = T(0);
       logm_utri_inplace(cS);
       gmm::mult(cQ, cS, auxmat);
       gmm::mult(auxmat, gmm::transposed(cQ), cS);




reply via email to

[Prev in Thread] Current Thread [Next in Thread]