[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Geiser-users] [PATCH] Connecting to a Unix-domain socket
From: |
Jose A. Ortega Ruiz |
Subject: |
Re: [Geiser-users] [PATCH] Connecting to a Unix-domain socket |
Date: |
Tue, 25 Feb 2014 00:53:14 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Hi,
On Tue, Feb 18 2014, Ludovic Courtès wrote:
> Hello!
>
> The patches below allow Geiser to connect to a Unix-domain socket via
> M-x geiser-connect-local.
>
> It works for me, but I’m not too familiar with elisp, so proper review
> is in order. :-)
After a very quick look, they look good to me, except for a little
detail. Here:
[...]
> diff --git a/elisp/geiser-repl.el b/elisp/geiser-repl.el
> index 995bb3b..316e6ea 100644
> --- a/elisp/geiser-repl.el
> +++ b/elisp/geiser-repl.el
> @@ -290,7 +290,7 @@ module command as a string")
> (marker-position (cdr comint-last-prompt)))
> ((and (boundp 'comint-last-prompt-overlay)
> comint-last-prompt-overlay)
> (overlay-end comint-last-prompt-overlay))
> - (t (save-excursion (geiser-repl--bol) (point)))))
> + (t (save-excursion (end-of-line) (point)))))
Why did you need to modify this bit? Is it related to unix-domain
socket support too?
Cheers,
jao
--
Everyone can be taught to sculpt: Michelangelo would have had to be
taught not to. So it is with great programmers.
- Alan Perlis, Epigrams in Programing