[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gcmd-dev] [patch] fix for bug 490431

From: Piotr Eljasiak
Subject: Re: [gcmd-dev] [patch] fix for bug 490431
Date: Thu, 29 Nov 2007 23:34:22 +0100

> Here's a fix for bug #490431
> (http://bugzilla.gnome.org/show_bug.cgi?id=490431). The code tried to
> unescape an already unescaped filename. This is fixed now. If you wish
> the codesize could be reduced by removing the 'arg' variable from the
> first part of the switch statement. But I left it as it was.

Thanks, applied. I've removed unnecessary vars.

> Wouldnt it be better to pass uri's to functions instead of filenames?

It'd be even better to pass to intviewer the list of currently selected
GnomeCmdFile *, to be able to navigate in intviewer through the selected
files. I've started some work on that but that's not finished yet...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]