Re: [gcmd-dev] gcc-4.2 bug?

[Piotr Eljasiak]

> About svn 1219 (you're fast, Piotr !)
> 
> >     * building problem with gcc-4.2
> 
> Still holds.
> 
> "gnome-cmd-tags.cc: In member function ‘void 
> GnomeCmdFileMetadata::addf(GnomeCmdTag, const gchar*, ...)’:
> 
> gnome-cmd-tags.cc:88: warning: comparison between signed and unsigned integer 
> expression"
> 
> 
> Although gcc-4.1 is default compiler for i386, gcc-4.2 is default compiler 
> for debian on amd64 now. So we should try to fix it...
> 
> I don't pretend i know any C. But 
> <http://www.thescripts.com/forum/thread568121.html> explains it quite simple. 
> Maybe buff.size() becomes unsigned when it gets out of range ?
> Or perhaps the check in line 88 can be done differently (calling for the next 
> error stop...)
> And if nothing else helps, then perhaps 
> <http://gcc.gnu.org/ml/gcc-help/2004-05/msg00047.html>


I believe I've fixed the problem with gcc-4.2. Could you verify it,
please? rev #1220 & #1221


Piotr