[Gcl-devel] Re: [Maxima] Rev 1.31 of src/nparse.lisp breaks windows build of CVS HEAD

[Camm Maguire]

Greetings!

I fixed the gcl reader to swallow trailing whitespace as part of the
read-char-no-hang fix.  But something was not right on Windows,
leading Mike Thomas to ifdef out the fix:

cvs -z9 -q diff -u -r 1.14.4.1.2.2.2.4.6.1.6.1.4.2 -r 
1.14.4.1.2.2.2.4.6.1.6.1.4.3 read.d
Index: read.d
===================================================================
RCS file: /cvsroot/gcl/gcl/o/read.d,v
retrieving revision 1.14.4.1.2.2.2.4.6.1.6.1.4.2
retrieving revision 1.14.4.1.2.2.2.4.6.1.6.1.4.3
diff -u -r1.14.4.1.2.2.2.4.6.1.6.1.4.2 -r1.14.4.1.2.2.2.4.6.1.6.1.4.3
--- read.d      7 Jun 2006 15:09:38 -0000       1.14.4.1.2.2.2.4.6.1.6.1.4.2
+++ read.d      16 Jun 2006 02:26:22 -0000      1.14.4.1.2.2.2.4.6.1.6.1.4.3
@@ -256,6 +256,7 @@
 
        x = read_object(in);
        vs_push(x);
+#ifndef _WIN32
        while (listen_stream(in)) {
          object c=read_char(in);
          if (cat(c)!=cat_whitespace) {
@@ -263,7 +264,7 @@
            break;
          }
        }
-
+#endif
        if (sharp_eq_context_max > 0)
                x = vs_head = patch_sharp(x);
 

----------------------------
revision 1.14.4.1.2.2.2.4.6.1.6.1.4.3
date: 2006-06-15 22:26:22 -0400;  author: mjthomas;  state: Exp;  lines: +2 -1
Band aid fix to stop build failure on Windows.


Mike, can this not go in on Windows?


I hope unix 4. below is the result of a maxima workaround which is no
longer necessary.  Please let me know if not.

Take care,

"Vadim V. Zhytnikov" <address@hidden> writes:

> Robert Dodier writes:
> > On 9/5/06, Billinghurst, David (CALCRTS)
> > <address@hidden> wrote:
> > 
> >> Revision 1.31 of src/nparse.lisp breaks windows build of CVS HEAD with
> >> gcl-2.6.7  As noted in the changelog, it hadn't been tested on windows.
> >>
> >> http://maxima.cvs.sourceforge.net/maxima/maxima/src/nparse.lisp?view=log
> 
> Finally I've got some time to see what is going here
> with 1483203 bug and both on Unix and Windows.
> Unfortunately results aren't good.  So something must be
> changed here but I don't quite understand what is the best way.
> 
> UNIX:
> 
> I've tested Maxima 5.10.0 (no fix for nparse applied yet)
> and Maxima CVS which includes nparse fix (Rev. 1.31)
> with gcl 2.6.7 and 2.6.8 cvs 26.10.2006.
> And here are some results:
> 
> 1. Maxima 5.10.0 + gcl 2.6.7 - problem with trailing space is
> here as expected.
> 
> 2. Maxima 5.10.0 + gcl 2.6.8 - no problem is observed.
> So probably the problem is fixed on gcl side.
> 
> 3. Maxima CVS + gcl 2.6.7 - once again no problems as expected.
> Fix to nparce.lisp works fine in this situation.
> 
> 4. Maxima CVS + gcl 2.6.8 - Bad!  Now input prompt is printed
> twice after expression with trailing.  This is probably result of
> new gcl 2.6.8 behavior.
> 
> Windows:
> 
> On Windows I've checked gcl 2.6.8 only and the really unpleasant
> thing is that result is quite different. First, I don't see that
> anything is broken.  Build went smooth and both Maxima versions
> 5.10.0 and CVS appear to be in workable state.  But!
> As long as the trailing space bug 1483203 is concerned
> both these versions behaves precisely like bug was not
> fixed at all - like 1 on UNIX.
> 
> I'm puzzled.
> 
> -- 
>       Vadim V. Zhytnikov
> 
>        <address@hidden>
>       <address@hidden>
> _______________________________________________
> Maxima mailing list
> address@hidden
> http://www.math.utexas.edu/mailman/listinfo/maxima
> 
> 
> 

-- 
Camm Maguire                                            address@hidden
==========================================================================
"The earth is but one country, and mankind its citizens."  --  Baha'u'llah