[Gap-dev-discuss] LuserNet: warning fix / code cleanup : char signedness

[Riccardo Mottola]

Hi,

(Yavor, are you on gap-dev? perhaps you should so we can avoid sending a 
lots of mails privately, I continued getting bounces from German for 
example, I fear he did not get half of our conversation)

trying to squeeze out some warnings in LuserNET, before its release 
together with Pantomime and GNUMail.

Alexander's code is for me very difficult to read and maintain, so I 
proceed extremely carefully and only fix stuff when really

On NetBSD I get an error that atoi() expects a const char*, not a 
unsigned char*. How is it on linux and other systems?

My first Idea was to apply the patch below instead of a cast, however 
that triggers another maze of warnings and errors.

Any proposals? I'd leave it as it is now... and not silence the cast if 
we are absolutely sure.

Index: NNTPServer.m
===================================================================
--- NNTPServer.m        (revision 310)
+++ NNTPServer.m        (working copy)
@@ -373,7 +373,7 @@
        int resp;
        int resp_code;            /* numeric code in status */
        char *resp_msg;           /* status message (if any) */
-       unsigned char *resp_buf;  /* read buffer */
+       char *resp_buf;  /* read buffer */
        int resp_buf_len;         /* length of buffer */
        int resp_data_len;        /* data has been processed up to this 
point */
        int resp_data_nline;
@@ -1767,7 +1767,7 @@
 }