Re: [Gap-dev-discuss] Fwd: Cynthiune: Two Problems

[Sebastian Reitenbach]

On Wednesday, February 19, 2014 16:52 CET, Richard Stonehouse <address@hidden> 
wrote: 
 
> Hi Riccardo,
> 
> On Wed, Feb 19, 2014 at 09:04:26AM +0100, Riccardo Mottola wrote:
> >Hi Richard,
> >
> >thanks for your report. I'm forwarding this to the gap-dev list so 
> >that other can contribute to the discussion. The first question is to 
> >reproduce the problem
> >
> >I admittedly did not test FLAC since I don't have such files, perhaps 
> >Sebastian did?
> 
> Attached is a FLAC test file. It's one I generated using a conversion 
> program. I've also tested on a FLAC file downloaded from the web.

See the patch I have attached here to fix the FLAC problem.

http://savannah.nongnu.org/bugs/?39954

Let me know if that fixes the problem for you too, and I'll go ahead
commit it.

The MP3 issue, I haven't yet had time to either reproduce, or even
look at it.

cheers,
Sebastian

> 
> >I do use(d) Cynthiune to play MP3 files quite a bit. Does it happen 
> >with all MP3 files or only with a certain file?
> 
> It happens with all the MP3 files I've tried - both ones I've 
> generated using lame and ones I've downloaded.
> 
> Having listened to a few more, it seems that the 'twittering' noise is 
> actually a delayed echo of the original sound, grossly distorted.
> 
> By the way, I should have mentioned that au, wav and ogg work fine.
> 
> >Or perhaps something bitrotted again. I'll attempt a build today.
> >
> >Riccardo
> 
> >Date: Wed, 19 Feb 2014 01:41:08 +0000
> >From: Richard Stonehouse <address@hidden>
> >To: Riccardo Mottola <address@hidden>
> >Subject: Cynthiune: Two Problems
> >User-Agent: Mutt/1.5.21 (2010-09-15)
> >
> >Hi Riccardo,
> >
> >I've built Cynthiune - congratulations on getting this out of 
> >intensive care! - but hit a couple of possible problems:
> >
> >1.  Crash on adding a FLAC file to playlist
> >
> >    Adding a FLAC file to the playlist caused Cynthiune to crash
> >    with a Segmentation fault. Tested both with a home-generated
> >    FLAC file and a downloaded one. Both work OK in other software.
> >
> >    gdb output as follows:
> >
> >Program received signal SIGSEGV, Segmentation fault.
> >0x00007fffe95d1031 in FLAC__stream_decoder_finish ()
> >   from /usr/lib64/libFLAC.so.8
> >(gdb) bt
> >#0  0x00007fffe95d1031 in FLAC__stream_decoder_finish ()
> >   from /usr/lib64/libFLAC.so.8
> >#1  0x00007fffe95d1367 in FLAC__stream_decoder_delete ()
> >   from /usr/lib64/libFLAC.so.8
> >#2  0x00007fffe5708ab5 in -[FLAC streamClose] (self=0x13b3d80, 
> >_cmd=0x6435f0 <_OBJC_SELECTOR_TABLE+592>) at FLAC.m:206
> >#3  0x000000000041ed14 in -[Song _refreshSongInfos] (self=0x11c2470, 
> >_cmd=0x643610 <_OBJC_SELECTOR_TABLE+624>) at Song.m:239
> >#4  0x000000000041ed86 in -[Song _readInfos] (self=0x11c2470, 
> >_cmd=0x643650 <_OBJC_SELECTOR_TABLE+688>) at Song.m:248
> >#5  0x0000000000420066 in -[Song encodeWithCoder:] (self=0x11c2470, 
> >_cmd=0x7ffff727ff10 <_OBJC_SELECTOR_TABLE+496>, encoder=0x13a0570)
> >    at Song.m:500
> >#6  0x00007ffff6d87a35 in -[NSKeyedArchiver(Private) 
> >_encodeObject:conditional:] (self=0x13a0570, _cmd=0x7ffff727fe60 
> ><_OBJC_SELECTOR_TABLE+320>, anObject=0x11c2470, conditional=0 '\000') 
> >at NSKeyedArchiver.m:361
> >#7  0x00007ffff6d87086 in -[NSKeyedArchiver(Internal) 
> >_encodeArrayOfObjects:forKey:] (self=0x13a0570, _cmd=0x7ffff72427e0 
> ><_OBJC_SELECTOR_TABLE+544>, anArray=0xbf4920, aKey=0x7ffff7241160 
> ><_OBJC_INSTANCE_3>)
> >    at NSKeyedArchiver.m:172
> >#8  0x00007ffff6ce90d0 in -[NSArray encodeWithCoder:] (self=0xbf4920, 
> >_cmd=0x7ffff7220470 <_OBJC_SELECTOR_TABLE+272>, aCoder=0x13a0570)
> >    at NSArray.m:442
> >#9  0x00007ffff6c8a608 in -[GSArray encodeWithCoder:] (self=0xbf4920, 
> >_cmd=0x7ffff727ff10 <_OBJC_SELECTOR_TABLE+496>, aCoder=0x13a0570)
> >    at GSArray.m:189
> >#10 0x00007ffff6d87a35 in -[NSKeyedArchiver(Private) 
> >_encodeObject:conditional:] (self=0x13a0570, _cmd=0x7ffff727fe60 
> ><_OBJC_SELECTOR_TABLE+320>, anObject=0xbf4920, conditional=0 '\000') 
> >at NSKeyedArchiver.m:361
> >#11 0x00007ffff6d89f59 in -[NSKeyedArchiver encodeObject:forKey:] (
> >    self=0x13a0570, _cmd=0x7ffff727ff70 <_OBJC_SELECTOR_TABLE+592>, 
> >anObject=0xbf4920, aKey=0x7ffff727f120 <_OBJC_INSTANCE_10>)
> >    at NSKeyedArchiver.m:675
> >#12 0x00007ffff6d87e1b in +[NSKeyedArchiver 
> >archivedDataWithRootObject:] (
> >    self=0x7ffff727fba0 <_OBJC_Class_NSKeyedArchiver>, 
> >_cmd=0x7ffff727ffc0 <_OBJC_SELECTOR_TABLE+672>, anObject=0xbf4920)
> >    at NSKeyedArchiver.m:456
> >#13 0x00007ffff6d87fe4 in +[NSKeyedArchiver 
> >archiveRootObject:toFile:] (
> >    self=0x7ffff727fba0 <_OBJC_Class_NSKeyedArchiver>, _cmd=0x639360 
> ><_OBJC_SELECTOR_TABLE+864>, anObject=0xbf4920, aPath=0xbf1920) at 
> >NSKeyedArchiver.m:478
> >#14 0x000000000041383a in -[Playlist saveToFile:] (self=0xbf18a0, 
> >_cmd=0x63d390 <_OBJC_SELECTOR_TABLE+2288>, file=0xbf1920) at 
> >Playlist.m:608
> >#15 0x00000000004191f8 in -[PlaylistController playlistChanged:] (
> >    self=0xbf1990, _cmd=0x639060 <_OBJC_SELECTOR_TABLE+96>, 
> >aNotification=0x13a0df0) at PlaylistController.m:1083
> >#16 0x00007ffff6db9893 in -[NSObject performSelector:withObject:] (
> >    self=0xbf1990, _cmd=0x7ffff728fcf0 <_OBJC_SELECTOR_TABLE+400>, 
> >aSelector=0x639060 <_OBJC_SELECTOR_TABLE+96>, anObject=0x13a0df0)
> >    at NSObject.m:2034
> >#17 0x00007ffff6daa632 in -[NSNotificationCenter _postAndRelease:] (
> >    self=0x738850, _cmd=0x7ffff728fd00 <_OBJC_SELECTOR_TABLE+416>, 
> >notification=0x13a0df0) at NSNotificationCenter.m:1191
> >#18 0x00007ffff6daa8e2 in -[NSNotificationCenter 
> >postNotificationName:object:userInfo:] (self=0x738850, _cmd=0x6390a0 
> ><_OBJC_SELECTOR_TABLE+160>, name=0x638800 <_OBJC_INSTANCE_0>, 
> >object=0xbf18a0, info=0x13a0d90)
> >    at NSNotificationCenter.m:1250
> >#19 0x0000000000410eac in -[Playlist 
> >postNotificationWithSongAsFirst:] (
> >    self=0xbf18a0, _cmd=0x6390f0 <_OBJC_SELECTOR_TABLE+240>, 
> >song=0x11c2470)
> >    at Playlist.m:100
> >#20 0x00000000004112b8 in -[Playlist addSongsInArray:] 
> >(self=0xbf18a0, _cmd=0x63d170 <_OBJC_SELECTOR_TABLE+1744>, 
> >array=0x138b4e0)
> >    at Playlist.m:150
> >#21 0x000000000041669b in -[PlaylistController 
> >_feedPlaylistWithTreeOfFilenames:] (self=0xbf1990, _cmd=0x63d130 
> ><_OBJC_SELECTOR_TABLE+1680>, filenames=0x1344eb0) at 
> >PlaylistController.m:535
> >#22 0x0000000000416747 in -[PlaylistController 
> >_oPanelDidEnd:returnCode:contextInfo:] (self=0xbf1990, _cmd=0x63d250 
> ><_OBJC_SELECTOR_TABLE+1968>, oPanel=0xf90250, result=1, 
> >contextInfo=0x0) at PlaylistController.m:546
> >#23 0x0000000000416c77 in -[PlaylistController 
> >_runOpenPanelWithDidEndSelector:] (self=0xbf1990, _cmd=0x63d280 
> ><_OBJC_SELECTOR_TABLE+2016>, selector=0x63d4e0 
> ><_OBJC_SELECTOR_TABLE+2624>) at PlaylistController.m:611
> >#24 0x00000000004181f4 in -[PlaylistController eject:] 
> >(self=0xbf1990, _cmd=0xe66dc0, sender=0xbd3180) at 
> >PlaylistController.m:890
> >#25 0x00007ffff753545b in -[NSApplication sendAction:to:from:] 
> >(self=0x806ce0, _cmd=0x7ffff7a9b320 <_OBJC_SELECTOR_TABLE+1312>, 
> >aSelector=0xe66dc0, aTarget=0xbf1990, sender=0xbd3180) at 
> >NSApplication.m:2230
> >#26 0x00007ffff75aac9c in -[NSControl sendAction:to:] (self=0xbd3180, 
> >_cmd=0x7ffff7a81010 <_OBJC_SELECTOR_TABLE+1392>, theAction=0xe66dc0, 
> >theTarget=0xbf1990) at NSControl.m:760
> >#27 0x00007ffff757b442 in -[NSCell _sendActionFrom:] (self=0xbd3560, 
> >_cmd=0x7ffff7a810b0 <_OBJC_SELECTOR_TABLE+1552>, sender=0xbd3180)
> >    at NSCell.m:1451
> >#28 0x00007ffff757c6ba in -[NSCell 
> >trackMouse:inRect:ofView:untilMouseUp:] (
> >    self=0xbd3560, _cmd=0x7ffff7a9b450 <_OBJC_SELECTOR_TABLE+1616>, 
> >theEvent=0xf7ebc0, cellFrame=..., controlView=0xbd3180, flag=0 
> >'\000')
> >    at NSCell.m:1769
> >#29 0x00007ffff75ab49c in -[NSControl mouseDown:] (self=0xbd3180, 
> >_cmd=0x7ffff7b75b40 <_OBJC_SELECTOR_TABLE+7200>, theEvent=0x9c5270)
> >    at NSControl.m:916
> >#30 0x00007ffff771c970 in -[NSWindow sendEvent:] (self=0xbbf640, 
> >_cmd=0x7ffff7a60360 <_OBJC_SELECTOR_TABLE+4864>, theEvent=0x9c5270)
> >    at NSWindow.m:3896
> >#31 0x00007ffff7534fa1 in -[NSApplication sendEvent:] (self=0x806ce0, 
> >_cmd=0x7ffff7a601d0 <_OBJC_SELECTOR_TABLE+4464>, theEvent=0x9c5270)
> >    at NSApplication.m:2105
> >#32 0x00007ffff7533aa7 in -[NSApplication run] (self=0x806ce0, 
> >_cmd=0x7ffff7a4fdf0 <_OBJC_SELECTOR_TABLE+1808>) at 
> >NSApplication.m:1562
> >#33 0x00007ffff750fe15 in NSApplicationMain (argc=1, 
> >argv=0x7fffffffe008)
> >    at Functions.m:91
> >#34 0x0000000000403bd0 in main (argc=1, argv=0x7fffffffe008) at 
> >main.m:27
> >
> >
> >2.  Twittering noise on playing MP3 file
> >
> >    Playing an MP3 file, it started off OK but after a second or
> >    two a loud, high-pitched twittering noise began. The original
> >    tune could still (just) be heard beneath the twittering. Tested
> >    both with a home-generated MP3 and a downloaded one. Both
> >    work OK in other software including madplay which, I think,
> >    uses the same library (libmad) as Cynthiune.
> >
> >These tests were run both on the tarball release of Cynthiune, 
> >version 1.0.0, and on the latest current SVN (rev 2266). Cynthiune 
> >was built with:
> >
> >    make debug=yes \
> >     disable-mod=yes \
> >     disable-windowsmedia=yes \
> >     disable-musepack=yes
> >
> >    make DESTDIR=${RPM_BUILD_ROOT} \
> >     GNUSTEP_INSTALLATION_DOMAIN=SYSTEM \
> >     disable-mod=yes \
> >     disable-windowsmedia=yes \
> >     disable-musepack=yes \
> >     strip=no \
> >     install
> >
> >
> >(mod, windowsmedia and musepack disabled because I don't have the 
> >required dependencies installed). There were no apparent problems in 
> >the build.
> >
> >-- 
> >    Richard Stonehouse
> 
> 
> -- 
>      Richard Stonehouse