gap-dev-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gap-dev-discuss] get rid of #ifdef MACOSX in GNUMail's MailWindowContro


From: Sebastian Reitenbach
Subject: [Gap-dev-discuss] get rid of #ifdef MACOSX in GNUMail's MailWindowController.m
Date: Sat, 01 Sep 2012 10:37:27 +0200
User-agent: SOGoMail 1.3.17

Hi,

the patch below should not change anything. A) because setIndicatorImage: inTableColumn: doesn't do anything than printing out that it is not yet implemented, and B) I've found a similar usage of the NSAscendingSortIndicator/NSDescendingSortIndicator in gnustep-gui NSTableHeaderCell.m, in
- (void) drawSortIndicatorWithFrame: (NSRect)cellFrame
inView: (NSView *)controlView
ascending: (BOOL)ascending
priority: (int)priority

so OK?

Sebastian

$OpenBSD$
--- Framework/GNUMail/MailWindowController.m.orig Wed Aug 29 14:33:43 2012
+++ Framework/GNUMail/MailWindowController.m    Wed Aug 29 14:34:04 2012
@@ -3191,19 +3191,11 @@

   if ([dataView isReverseOrder])
     {
-#ifdef MACOSX
[dataView setIndicatorImage: [NSImage imageNamed: @"NSAscendingSortIndicator"] inTableColumn: aTableColumn];
-#else
- [dataView setIndicatorImage: [NSImage imageNamed: @"sort_up.tiff"] inTableColumn: aTableColumn];
-#endif
     }
   else
     {
-#ifdef MACOSX
[dataView setIndicatorImage: [NSImage imageNamed: @"NSDescendingSortIndicator"] inTableColumn: aTableColumn];
-#else
- [dataView setIndicatorImage: [NSImage imageNamed: @"sort_down.tiff"] inTableColumn: aTableColumn];
-#endif
     }
 }




reply via email to

[Prev in Thread] Current Thread [Next in Thread]