Re: [Gap-dev-discuss] Cynthiune : make ALSA output handle parameter changes between song

[Philippe Roussel]

Hi,

Le 24/05/2012 00:12, Riccardo Mottola a écrit :
>> Could you try the following ? The device handle wasn't protected in all
>> sites.
>>    
> Thanks for this patch! I applied it manually (sometimes your messages
> inline instead of being attached, so they corrupt).

Sorry, I thought Thunderbird was doing the right thing when inlining a
patch. I will try to attach them from now on.

> With thispatch, I can now play differently endianned songs! Wav and MP3s
> mixed. Very good!  I commited it.

Great news !

> What remains, is that certain files (which are not 44Khz/stereo) issue
> an exception as before, but I had no further time to investigate that
> and provide you stacktraces, sorry.

No worries, we're all busy. But you will probably have to debug this
because I can't reproduce it here.

One thing you could try is to add

en = SND_PCM_FORMAT_S16;

in [ALSA -init]. I'm quite sure this isn't needed because -openDevice
should always be called after -prepareDeviceWithChannels: but I could be
wrong and it doesn't cost much.

Thanks,
Philippe