Re: [Gap-dev-discuss] Fixing Cynthiune Timidity Bundle

[Sebastian Reitenbach]

On Monday, May 14, 2012 10:04 CEST, Philippe Roussel <address@hidden> wrote:

> Hi,
>
> Le 13/05/2012 20:56, Riccardo Mottola a écrit :
> > Hi,
> >
> > I don't know how to handle the executable stuff, but your buffer patch
> > seems sane, thus commit it!
>
> This simple patch is enough to keep Cynthiune alive when adding .mid

> files without Timidity.

This looks good, and after a short test, also works for me.
I commited it, thanks.


>
> It also shows that the code could be improved : when adding one .mid

> file to the playlist, the error message appears *8* times...

I saw that too, probably indeed room for many improvements ;)

Sebastian

>
> Thanks,
> Philippe
>
>
> RCS file: /sources/gap/gap/user-apps/Cynthiune/Bundles/Timidity/Timidity.m,v
> retrieving revision 1.4
> diff -u -r1.4 Timidity.m
> --- Bundles/Timidity/Timidity.m       13 May 2012 16:56:42 -0000      1.4
> +++ Bundles/Timidity/Timidity.m       14 May 2012 08:02:28 -0000
> @@ -135,7 +135,16 @@
>    in = [tiPipe fileHandleForReading];
>    err = [stderrPipe fileHandleForReading];
>
> -  [tiTask launch];
> +
> +  NS_DURING
> +    {
> +      [tiTask launch];
> +    }
> +  NS_HANDLER
> +    {
> +      NSLog(@"Error while lauching task '%@'", [tiTask launchPath]);
> +    }
> +  NS_ENDHANDLER
>
>    if ([tiTask isRunning])
>      {
>