Re: [ft-devel] Prototypes of memory debugging routines on WIN64

[Alexei Podtelezhnikov]

> >> Indeed, size_t is the correct C89-compliant type. Would it hurt to
> >> modify FT_Alloc_Func and FT_Realloc_Func?
> >
> > Ping! (with a patch)
>
> Looks good!  Provided we can use it without breaking the ABI, please
> proceed.

The ABI checker report is attached. The change is noticed but
permitted, I think. I was checking on LP64, where sizes of long and
size_t match. They do not match on LLP64, which we are actually trying
to fix. Should proceed with the patch? In addition I wonder if the
entire ftdbgmem.c should be reworked with size_t instead of FT_Long.

API compatibility report for the libfreetype.so object between 0 and 1 versions on x86_64

Binary
Compatibility Source
Compatibility

Test Info

---

Module Name	freetype
Version #1	0
Version #2	1
Arch	x86_64
GCC Version	7.3.1
Subject	Binary Compatibility

Test Results

---

Total Header Files	37
Total Source Files	35
Total Objects	1
Total Symbols / Types	205 / 446
Compatibility	100%

Problem Summary

---

	Severity	Count
Added Symbols	-	0
Removed Symbols	High	0
Problems with Data Types	High	0
	Medium	0
	Low	2
Problems with Symbols	High	0
	Medium	0
	Low	0
Problems with Constants	Low	0

Problems with Data Types, Low Severity  2 

---

ftsystem.h
[+] typedef FT_Alloc_Func  1 

	Change	Effect
1	Base type has been changed from void*(*)(FT_Memory, long) to void*(*)(FT_Memory, size_t).	Replacement of the base data type may indicate a change in its semantic meaning.

[+] affected symbols: 148 (72.2%)

FT_Add_Default_Modules ( FT_Library library )

Field 'library.auto_hinter.memory.alloc' in 1st parameter 'library' (pointer) is of type 'FT_Alloc_Func'.

FT_Add_Module ( FT_Library library, FT_Module_Class const* clazz )

Field 'library.auto_hinter.memory.alloc' in 1st parameter 'library' (pointer) is of type 'FT_Alloc_Func'.

FT_Attach_File ( FT_Face face, char const* filepathname )

Field 'face.driver.root.memory.alloc' in 1st parameter 'face' (pointer) is of type 'FT_Alloc_Func'.

FT_Attach_Stream ( FT_Face face, FT_Open_Args* parameters )

Field 'face.driver.root.memory.alloc' in 1st parameter 'face' (pointer) is of type 'FT_Alloc_Func'.

FT_Bitmap_Blend ( FT_Library library, FT_Bitmap const* source_, FT_Vector const source_offset_, FT_Bitmap* target, FT_Vector* atarget_offset, FT_Color color )

Field 'library.auto_hinter.memory.alloc' in 1st parameter 'library' (pointer) is of type 'FT_Alloc_Func'.

FT_Bitmap_Convert ( FT_Library library, FT_Bitmap const* source, FT_Bitmap* target, FT_Int alignment )

Field 'library.auto_hinter.memory.alloc' in 1st parameter 'library' (pointer) is of type 'FT_Alloc_Func'.

FT_Bitmap_Copy ( FT_Library library, FT_Bitmap const* source, FT_Bitmap* target )

Field 'library.auto_hinter.memory.alloc' in 1st parameter 'library' (pointer) is of type 'FT_Alloc_Func'.

FT_Bitmap_Done ( FT_Library library, FT_Bitmap* bitmap )

Field 'library.auto_hinter.memory.alloc' in 1st parameter 'library' (pointer) is of type 'FT_Alloc_Func'.

FT_Bitmap_Embolden ( FT_Library library, FT_Bitmap* bitmap, FT_Pos xStrength, FT_Pos yStrength )

Field 'library.auto_hinter.memory.alloc' in 1st parameter 'library' (pointer) is of type 'FT_Alloc_Func'.

FT_ClassicKern_Free ( FT_Face face, FT_Bytes table )

Field 'face.driver.root.memory.alloc' in 1st parameter 'face' (pointer) is of type 'FT_Alloc_Func'.

...

[+] typedef FT_Realloc_Func  1 

	Change	Effect
1	Base type has been changed from void*(*)(FT_Memory, long, long, void*) to void*(*)(FT_Memory, size_t, size_t, void*).	Replacement of the base data type may indicate a change in its semantic meaning.

[+] affected symbols: 148 (72.2%)

FT_Add_Default_Modules ( FT_Library library )

Field 'library.auto_hinter.memory.realloc' in 1st parameter 'library' (pointer) is of type 'FT_Realloc_Func'.

FT_Add_Module ( FT_Library library, FT_Module_Class const* clazz )

Field 'library.auto_hinter.memory.realloc' in 1st parameter 'library' (pointer) is of type 'FT_Realloc_Func'.

FT_Attach_File ( FT_Face face, char const* filepathname )

Field 'face.driver.root.memory.realloc' in 1st parameter 'face' (pointer) is of type 'FT_Realloc_Func'.

FT_Attach_Stream ( FT_Face face, FT_Open_Args* parameters )

Field 'face.driver.root.memory.realloc' in 1st parameter 'face' (pointer) is of type 'FT_Realloc_Func'.

FT_Bitmap_Blend ( FT_Library library, FT_Bitmap const* source_, FT_Vector const source_offset_, FT_Bitmap* target, FT_Vector* atarget_offset, FT_Color color )

Field 'library.auto_hinter.memory.realloc' in 1st parameter 'library' (pointer) is of type 'FT_Realloc_Func'.

FT_Bitmap_Convert ( FT_Library library, FT_Bitmap const* source, FT_Bitmap* target, FT_Int alignment )

Field 'library.auto_hinter.memory.realloc' in 1st parameter 'library' (pointer) is of type 'FT_Realloc_Func'.

FT_Bitmap_Copy ( FT_Library library, FT_Bitmap const* source, FT_Bitmap* target )

Field 'library.auto_hinter.memory.realloc' in 1st parameter 'library' (pointer) is of type 'FT_Realloc_Func'.

FT_Bitmap_Done ( FT_Library library, FT_Bitmap* bitmap )

Field 'library.auto_hinter.memory.realloc' in 1st parameter 'library' (pointer) is of type 'FT_Realloc_Func'.

FT_Bitmap_Embolden ( FT_Library library, FT_Bitmap* bitmap, FT_Pos xStrength, FT_Pos yStrength )

Field 'library.auto_hinter.memory.realloc' in 1st parameter 'library' (pointer) is of type 'FT_Realloc_Func'.

FT_ClassicKern_Free ( FT_Face face, FT_Bytes table )

Field 'face.driver.root.memory.realloc' in 1st parameter 'face' (pointer) is of type 'FT_Realloc_Func'.

...

to the top

Header Files  37 

---

freetype.h
ftadvanc.h
ftbdf.h
ftbitmap.h
ftcache.h
ftccache.h
ftcmanag.h
ftcmru.h
ftcolor.h
ftconfig.h
ftdrv.h
ftgloadr.h
ftglyph.h
ftimage.h
ftincrem.h
ftlcdfil.h
ftlist.h
ftmm.h
ftmodapi.h
ftobjs.h
ftoutln.h
ftrender.h
ftserv.h
ftsizes.h
ftsnames.h
ftstroke.h
ftsystem.h
fttrigon.h
fttypes.h
ftwinfnt.h
stddef.h
t1tables.h
ttgxvar.h
ttinterp.h
ttobjs.h
tttables.h
tttypes.h

to the top

Source Files  35 

---

ftadvanc.c
ftbbox.c
ftbdf.c
ftbitmap.c
ftbzip2.c
ftcalc.c
ftcbasic.c
ftccmap.c
ftcid.c
ftcmanag.c
ftcolor.c
fterrors.c
ftfntfmt.c
ftfstype.c
ftgasp.c
ftglyph.c
ftgxval.c
ftgzip.c
ftinit.c
ftlcdfil.c
ftlzw.c
ftmm.c
ftobjs.c
ftotval.c
ftoutln.c
ftpatent.c
ftpfr.c
ftsnames.c
ftstroke.c
ftsynth.c
fttrigon.c
fttype1.c
ftutil.c
ftwinfnt.c
ttinterp.c

to the top

Objects  1 

---

libfreetype.so.6.16.1

to the top

Test Info

---

Module Name	freetype
Version #1	0
Version #2	1
Arch	x86_64
Subject	Source Compatibility

Test Results

---

Total Header Files	37
Total Source Files	35
Total Objects	1
Total Symbols / Types	205 / 446
Compatibility	100%

Problem Summary

---

	Severity	Count
Added Symbols	-	0
Removed Symbols	High	0
Problems with Data Types	High	0
	Medium	0
	Low	2
Problems with Symbols	High	0
	Medium	0
	Low	0
Problems with Constants	Low	0

Problems with Data Types, Low Severity  2 

---

ftsystem.h
[+] typedef FT_Alloc_Func  1 

	Change	Effect
1	Base type has been changed from void*(*)(FT_Memory, long) to void*(*)(FT_Memory, size_t).	Recompilation of a client program may be broken.

[+] affected symbols: 148 (72.2%)

FT_Add_Default_Modules ( FT_Library library )

Field 'library.auto_hinter.memory.alloc' in 1st parameter 'library' (pointer) is of type 'FT_Alloc_Func'.

FT_Add_Module ( FT_Library library, FT_Module_Class const* clazz )

Field 'library.auto_hinter.memory.alloc' in 1st parameter 'library' (pointer) is of type 'FT_Alloc_Func'.

FT_Attach_File ( FT_Face face, char const* filepathname )

Field 'face.driver.root.memory.alloc' in 1st parameter 'face' (pointer) is of type 'FT_Alloc_Func'.

FT_Attach_Stream ( FT_Face face, FT_Open_Args* parameters )

Field 'face.driver.root.memory.alloc' in 1st parameter 'face' (pointer) is of type 'FT_Alloc_Func'.

FT_Bitmap_Blend ( FT_Library library, FT_Bitmap const* source_, FT_Vector const source_offset_, FT_Bitmap* target, FT_Vector* atarget_offset, FT_Color color )

Field 'library.auto_hinter.memory.alloc' in 1st parameter 'library' (pointer) is of type 'FT_Alloc_Func'.

FT_Bitmap_Convert ( FT_Library library, FT_Bitmap const* source, FT_Bitmap* target, FT_Int alignment )

Field 'library.auto_hinter.memory.alloc' in 1st parameter 'library' (pointer) is of type 'FT_Alloc_Func'.

FT_Bitmap_Copy ( FT_Library library, FT_Bitmap const* source, FT_Bitmap* target )

Field 'library.auto_hinter.memory.alloc' in 1st parameter 'library' (pointer) is of type 'FT_Alloc_Func'.

FT_Bitmap_Done ( FT_Library library, FT_Bitmap* bitmap )

Field 'library.auto_hinter.memory.alloc' in 1st parameter 'library' (pointer) is of type 'FT_Alloc_Func'.

FT_Bitmap_Embolden ( FT_Library library, FT_Bitmap* bitmap, FT_Pos xStrength, FT_Pos yStrength )

Field 'library.auto_hinter.memory.alloc' in 1st parameter 'library' (pointer) is of type 'FT_Alloc_Func'.

FT_ClassicKern_Free ( FT_Face face, FT_Bytes table )

Field 'face.driver.root.memory.alloc' in 1st parameter 'face' (pointer) is of type 'FT_Alloc_Func'.

...

[+] typedef FT_Realloc_Func  1 

	Change	Effect
1	Base type has been changed from void*(*)(FT_Memory, long, long, void*) to void*(*)(FT_Memory, size_t, size_t, void*).	Recompilation of a client program may be broken.

[+] affected symbols: 148 (72.2%)

FT_Add_Default_Modules ( FT_Library library )

Field 'library.auto_hinter.memory.realloc' in 1st parameter 'library' (pointer) is of type 'FT_Realloc_Func'.

FT_Add_Module ( FT_Library library, FT_Module_Class const* clazz )

Field 'library.auto_hinter.memory.realloc' in 1st parameter 'library' (pointer) is of type 'FT_Realloc_Func'.

FT_Attach_File ( FT_Face face, char const* filepathname )

Field 'face.driver.root.memory.realloc' in 1st parameter 'face' (pointer) is of type 'FT_Realloc_Func'.

FT_Attach_Stream ( FT_Face face, FT_Open_Args* parameters )

Field 'face.driver.root.memory.realloc' in 1st parameter 'face' (pointer) is of type 'FT_Realloc_Func'.

FT_Bitmap_Blend ( FT_Library library, FT_Bitmap const* source_, FT_Vector const source_offset_, FT_Bitmap* target, FT_Vector* atarget_offset, FT_Color color )

Field 'library.auto_hinter.memory.realloc' in 1st parameter 'library' (pointer) is of type 'FT_Realloc_Func'.

FT_Bitmap_Convert ( FT_Library library, FT_Bitmap const* source, FT_Bitmap* target, FT_Int alignment )

Field 'library.auto_hinter.memory.realloc' in 1st parameter 'library' (pointer) is of type 'FT_Realloc_Func'.

FT_Bitmap_Copy ( FT_Library library, FT_Bitmap const* source, FT_Bitmap* target )

Field 'library.auto_hinter.memory.realloc' in 1st parameter 'library' (pointer) is of type 'FT_Realloc_Func'.

FT_Bitmap_Done ( FT_Library library, FT_Bitmap* bitmap )

Field 'library.auto_hinter.memory.realloc' in 1st parameter 'library' (pointer) is of type 'FT_Realloc_Func'.

FT_Bitmap_Embolden ( FT_Library library, FT_Bitmap* bitmap, FT_Pos xStrength, FT_Pos yStrength )

Field 'library.auto_hinter.memory.realloc' in 1st parameter 'library' (pointer) is of type 'FT_Realloc_Func'.

FT_ClassicKern_Free ( FT_Face face, FT_Bytes table )

Field 'face.driver.root.memory.realloc' in 1st parameter 'face' (pointer) is of type 'FT_Realloc_Func'.

...

to the top

Header Files  37 

---

freetype.h
ftadvanc.h
ftbdf.h
ftbitmap.h
ftcache.h
ftccache.h
ftcmanag.h
ftcmru.h
ftcolor.h
ftconfig.h
ftdrv.h
ftgloadr.h
ftglyph.h
ftimage.h
ftincrem.h
ftlcdfil.h
ftlist.h
ftmm.h
ftmodapi.h
ftobjs.h
ftoutln.h
ftrender.h
ftserv.h
ftsizes.h
ftsnames.h
ftstroke.h
ftsystem.h
fttrigon.h
fttypes.h
ftwinfnt.h
stddef.h
t1tables.h
ttgxvar.h
ttinterp.h
ttobjs.h
tttables.h
tttypes.h

to the top

Source Files  35 

---

ftadvanc.c
ftbbox.c
ftbdf.c
ftbitmap.c
ftbzip2.c
ftcalc.c
ftcbasic.c
ftccmap.c
ftcid.c
ftcmanag.c
ftcolor.c
fterrors.c
ftfntfmt.c
ftfstype.c
ftgasp.c
ftglyph.c
ftgxval.c
ftgzip.c
ftinit.c
ftlcdfil.c
ftlzw.c
ftmm.c
ftobjs.c
ftotval.c
ftoutln.c
ftpatent.c
ftpfr.c
ftsnames.c
ftstroke.c
ftsynth.c
fttrigon.c
fttype1.c
ftutil.c
ftwinfnt.c
ttinterp.c

to the top

Objects  1 

---

libfreetype.so.6.16.1

to the top

---

Generated by ABI Compliance Checker 2.3