Re: [ft-devel] Review commits

[Werner LEMBERG]

Hello Parth!


> I have committed some changes in my branch `parthw-wip'.

Thanks.

> Please review it and tell me any instructions you wish to give me.

Here they are.  Note that I did a quick look only, and everything
looks fine.

* Please replace all tabs with spaces.  It seems that you are using an
  editor that represents a tab with two spaces: This is another reason
  to use spaces only since this is non-standard (the default is
  8 spaces = 1 tab).

  [I know that this is your branch where you can do whatever you like,
   but you asked for review, and good indentation similar to the rest
   of the FreeType code makes a review simpler for me :-)]

* There are some comments of the form

    /*foo*/

  Please replace this eventually with

    /* foo */

  (And please don't use `//' comments in the final code.)

* Avoid trailing spaces, which stick out in ugly red if I use `git
  diff' :-) Many editors can be configured to automatically remove
  trailing spaces as soon as you are saving the file.

* gf.h: `INT1', `UINT1', etc. should be removed.  The code should then
  use `FT_Int', `FT_UInt', etc.  This is a minor issue and not urgent.

* Maybe you can replace `READ_INT1' and friends with similar macros
  and functions already defined in FreeType?  This is another minor
  issue.

* It might make sense to replace `int' and friends with smaller data
  types like `FT_UShort' in structure arrays where possible to get a
  smaller memory footprint.  (The stress is on `might' – maybe this is
  overkill.)

* Please avoid the use of `float' and `double'.  Right now, FreeType
  uses integer arithmetic only; `double' is only used for defining
  compile-time constants and in debug mode for displaying tracing
  messages.

  Theoretically, this shouldn't be very difficult since all parts of
  TeX are using integer arithmetic only – GF, PK, and TFM are no
  exception.

> P.S. Some part of the code can contain VFlib specific code please
>      ignore that, I will be changing it soon.

OK.


    Werner