Re: [ft-devel] Upstreaming freetype diagnostics patches

[Felipe Sanches]

Hello, Werner,

I've moved the diagnostics callback field into FT_Face_Internal.
The current proposal to fix to the globals issue is the aggregate of the following 2 commits:

https://github.com/felipesanches/freetype2/commit/dac77c3aeebbf2eee1647d3b95f5b5e3bf9d2db0
https://github.com/felipesanches/freetype2/commit/51ec98b528b395af25f03e8b3824964feaa5a89e

Please let me know if that's a good way of addressing the issue.

Cheers,

Felipe Sanches

2017-09-09 3:08 GMT-03:00 Felipe Sanches <address@hidden>:

Cool, thanks for the quick feedback! I'll see what  can do about it ;-)

2017-09-09 3:05 GMT-03:00 Werner LEMBERG <address@hidden>:

> I have adapted HinTak's b06 patch to address the globals usage issue
> that was originally brought up by Behdad.  He had suggested moving
> those globals to FT_Library, but I did place the diagnostics
> callback into the FT_Face struct, instead. Let me know if that's
> good.

No time to look right now.  However, FT_Face is a public structure and
thus taboo – you *must not* modify it!  Use FT_Face_Internal instead.


   Werner