[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [ft-devel] [GSoC] Moving CFF stuff into psaux module
From: |
Ewald Hew |
Subject: |
Re: [ft-devel] [GSoC] Moving CFF stuff into psaux module |
Date: |
Tue, 6 Jun 2017 22:58:31 +0800 |
> OK. Here a minor patch.
>
>
> diff --git a/src/cff/cffgload.c b/src/cff/cffgload.c
> index c27f74c3..e4721d74 100644
> --- a/src/cff/cffgload.c
> +++ b/src/cff/cffgload.c
> @@ -203,7 +203,7 @@
> FT_Bool hinting, scaled, force_scaling;
> CFF_Font cff = (CFF_Font)face->extra.data;
>
> - PSAux_Service psaux = face->psaux;
> + PSAux_Service psaux = (PSAux_Service)face->psaux;
> const CFF_Decoder_Funcs decoder_funcs = psaux->cff_decoder_funcs;
>
> FT_Matrix font_matrix;
Thanks for spotting that! I must have missed it while changing the
struct definitions halfway through.
> Please do logical, smaller commits. Simply add a sentence to the log
> message about not being able to compile the current commit.
Ok, will do.
> So it seems that you have already done a big step into the right
> direction. Two main issues are still to tackle, right?
>
> . Handle `cid' module.
>
> . Make the cff hinter handle Type1 (and CID) fonts also, as an
> alternative to the `pshinter' module.
Indeed. I will be working on the latter first.
Ewald.