Re: [ft-devel] [GSoC] ftinspect

[Philipp Kerling]

Am Sonntag, den 07.05.2017, 13:29 +0200 schrieb Werner LEMBERG:
> >> In patch 10 you are using the `auto' keyword.  My gut feeling says
> >> that `auto' is fine for templates and the like but otherwise
> normal
> >> types are preferable, especially if there is an explicit
> >> `static_cast' (additionally, it's a C++11 feature, but this item
> is
> >> unrelated). What do you think?
> 
> > For the combination of auto and a cast I see it as DRY feature. 
> The
> > type is/should be completely determined by the cast expression
> > anyway, so the variable type specification does not add any
> > information (i.e.  it is redundant) both for the compiler and the
> > human reader.  There's also an auto in patch 14, which I used for
> > inheriting the type (even if it should change later).  It clearly
> is
> > a matter of taste though and I wouldn't insist on using it.
> 
> OK, then please don't use `auto' yet.  If we are going to use it, I
> guess there are much more places where it makes sense, and it should
> be straightforward to convert all such places with a separate commit.
See v2 of the patchset attached. I
 * rebased on master (only change was light vs slight if I catched that
   correctly)
 * removed all C++11-related stuff (auto, override, static_assert,
   std::intptr_t)

ftinspect-refactor-v2.zip
Description: Zip archive