Re: [ft-devel] Cleaning up ttinterp

[Behdad Esfahbod]

On 14-10-14 10:17 PM, Werner LEMBERG wrote:
> 
>>> +1 if you preserve English descriptions and stack specs.
> 
> Yeah, this is a good thing.  Thanks for the reminder.
> 
>> Check again.  I cleaned it up some more, and all instruction
>> implementations in the switch are limited to two lines now.
> 
> Mhmm, we are still losing a lot of descriptions and stack specs.  I
> think they should be simply moved into the big switch statement.

I find the switch quite readable in the current state of my tree.  The only
exception is MPS.  I can move that to a function.

Which other ones do you want documented?  I don't see any value in
documenting, eg, these, as they are very self-documenting:

        case 0x4E:  /* FLIPOFF */
          exc->GS.auto_flip = FALSE;
          break;

        case 0x4F:  /* DEBUG */
          exc->error = FT_THROW( Debug_OpCode );
          break;

        case 0x50:  /* LT */
          args[0] = ( args[0] < args[1] );
          break;

        case 0x51:  /* LTEQ */
          args[0] = ( args[0] <= args[1] );
          break;

        case 0x52:  /* GT */
          args[0] = ( args[0] > args[1] );
          break;

        case 0x53:  /* GTEQ */
          args[0] = ( args[0] >= args[1] );
          break;

        case 0x54:  /* EQ */
          args[0] = ( args[0] == args[1] );
          break;

        case 0x55:  /* NEQ */
          args[0] = ( args[0] != args[1] );

-- 
behdad
http://behdad.org/