[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [ft-devel] WIP PATCH: clang static analyzer and warning fixes
|
From: |
Sean McBride |
|
Subject: |
Re: [ft-devel] WIP PATCH: clang static analyzer and warning fixes |
|
Date: |
Tue, 17 Jun 2014 10:29:32 -0400 |
On Mon, 16 Jun 2014 20:46:44 -0400, Alexei Podtelezhnikov said:
>> > Arghhhh... I am not sure if the patch is even correct. Aren't we
>> > resetting the variable in each loop cycle? This wasn't the case in
>> > the original code where the values reused, was it?
>>
>> Oops! You are right. Thanks for catching this; it's now reverted.
>>
>>
>Arghhhh!!! This thing (aflatin.c:571) got wrongly "fixed" again. Please
>revert with an inline comment so that people think rather than trust clang.
I submit that there is a code smell here. The code is funky enough to trick
two different tools, humans, and human reviewers. While it may be 'correct',
it's probably too complicated and should be refactored in some way.
Cheers,
--
____________________________________________________________
Sean McBride, B. Eng address@hidden
Rogue Research www.rogue-research.com
Mac Software Developer Montréal, Québec, Canada