[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [ft-devel] Two very minor freetype patch suggestions
From: |
Sean McBride |
Subject: |
Re: [ft-devel] Two very minor freetype patch suggestions |
Date: |
Fri, 1 Jun 2007 10:28:18 -0400 |
On 2007-06-01 08:49, Werner LEMBERG said:
>
>> 1) fttypes.h contain a tab char (line 387) could it be changed to
>> spaces? VTK will not allow commits of files with tabs, and freetype
>> seems to prefer spaces also.
>
>Fixed.
>
>> 2) A compiler warning (ftsystem.c:278):
>> <http://www.vtk.org/Testing/Sites/hythloth.kitware/Linux-
>gcc295/20070531-1517-Continuous/BuildWarning.html>
>>
>> I think changing ULONG_MAX to LONG_MAX is appropriate.
>
>Fixed. This is your code, BTW. :-)
Yes. :) That gave me a good laugh too. :) Thanks for the checkin.
Today's VTK build revealed a few more warnings too, from a machine using
the Borland compiler:
<http://www.vtk.org/Testing/Sites/dash19.kitware/Win32-
bcc32/20070601-0300-Nightly/BuildWarning.html>
They aren't as trivial, but perhaps you'd take a look?
Cheers,
--
____________________________________________________________
Sean McBride, B. Eng address@hidden
Rogue Research www.rogue-research.com
Mac Software Developer Montréal, Québec, Canada