Re: [Devel] bug + fix pcf driver

[Francesco Zappa Nardelli]

Hello again.

A second, little, bug has been fixed in the pcf driver.  Currently,
the driver is believed bug free, till the next bug report.

The attached patch replaces the patch I have sent one hour ago, and
should be applied to the pcfdriver.c file.  Sorry about that.

Suggested ChangeLog:

FIX: pcf driver: the bitmap width and the slot->bitmap_left fields
were incorrectly calculated.

$ diff -u pcfdriver.c pcfdriverNew.c              
--- pcfdriver.c Tue May  8 12:09:52 2001
+++ pcfdriverNew.c      Tue May  8 14:38:41 2001
@@ -158,7 +158,7 @@
     metric = face->metrics + glyph_index;
   
     bitmap->rows       = metric->ascent + metric->descent;
-    bitmap->width      = metric->characterWidth;
+    bitmap->width      = metric->rightSideBearing - metric->leftSideBearing;
     bitmap->num_grays  = 1;
     bitmap->pixel_mode = ft_pixel_mode_mono;
   
@@ -220,7 +220,7 @@
       }
     }
 
-    slot->bitmap_left = 0;
+    slot->bitmap_left = metric->leftSideBearing;
     slot->bitmap_top  = metric->ascent;
 
     slot->metrics.horiAdvance  = metric->characterWidth << 6 ;

Regards,
-francesco

pcffix.diff
Description: Text Data