freetype-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[freetype2] master 1937b55: [cff] Fix missing error handling.


From: Werner LEMBERG
Subject: [freetype2] master 1937b55: [cff] Fix missing error handling.
Date: Tue, 14 Aug 2018 01:54:40 -0400 (EDT)

branch: master
commit 1937b557341187eda5434a8a64da9880472c4cd4
Author: Werner Lemberg <address@hidden>
Commit: Werner Lemberg <address@hidden>

    [cff] Fix missing error handling.
    
    Reported as
    
      https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9865
    
    * src/psaux/cffparse.c (cff_parser_run)
    [CFF_CONFIG_OPTION_OLD_ENGINE]: Don't ignore return value of
    `parse_charstrings_old'.
---
 ChangeLog          | 12 ++++++++++++
 src/cff/cffparse.c |  2 ++
 2 files changed, 14 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index dddbe2c..2f373dd 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2018-08-14  Werner Lemberg  <address@hidden>
+
+       [cff] Fix missing error handling.
+
+       Reported as
+
+         https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9865
+
+       * src/psaux/cffparse.c (cff_parser_run)
+       [CFF_CONFIG_OPTION_OLD_ENGINE]: Don't ignore return value of
+       `parse_charstrings_old'.
+
 2018-08-14  Alexei Podtelezhnikov  <address@hidden>
 
        [bdf] Remove unused overflow storage.
diff --git a/src/cff/cffparse.c b/src/cff/cffparse.c
index b6f5dae..4b2ecc5 100644
--- a/src/cff/cffparse.c
+++ b/src/cff/cffparse.c
@@ -1231,6 +1231,8 @@
 
         error = psaux->cff_decoder_funcs->parse_charstrings_old(
                   &decoder, charstring_base, charstring_len, 1 );
+        if ( error )
+          goto Exit;
 
         /* Now copy the stack data in the temporary decoder object,    */
         /* converting it back to charstring number representations     */



reply via email to

[Prev in Thread] Current Thread [Next in Thread]