freepooma-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [pooma-dev] RFA: Permit NoGeometry Fields to Instantiate


From: Scott Haney
Subject: Re: [pooma-dev] RFA: Permit NoGeometry Fields to Instantiate
Date: Mon, 14 May 2001 15:01:47 -0600

These look fine to me.

Scott

On Monday, May 14, 2001, at 02:01 PM, Jeffrey Oldham wrote:

OK to commit?

This patch, composed of the three previous patches plus one minor
tweak, obviates those patches.  It permits compiling this program:

    #include "Pooma/NewFields.h"

    #define T1 NoGeometry<(int)3>
    #define T2 int
    #define T3 CompressibleBrick
    #define T4 Interval<(int)3>
    template class Field<T1,T2,T3>;
    template class View1<Field<T1,T2,T3>,T4>;

This program adds the "class Field" line to what Dave Nystrom
originally requested.  This reflects circular references in the
definition of View1.  Next, I will work on eliminating the need to add
the line.

2001-05-14  Jeffrey D. Oldham  <address@hidden>

        * Array/Array.h: Add View0 to comment listing implemented classes.
        (Array::innerDomain): Remove the function since engines do not
        implement it.
        * Domain/DomainTraits.Region.h
        (DomainTraits<Region<1,POOMA_DEFAULT_POSITION_TYPE> >::empty():
        Remove name of unused parameter.
        * Engine/CompressibleBlock.h
        (CompressibleBlockController::CompressibleBlockController):
        Reorder member initialization order.
        * Engine/CompressibleBrick.cpp
        (Engine<Dim,T,CompressibleBrickView>::makeOwnCopy()): New
        function.
        * Engine/CompressibleBrick.h (Engine<Dim, T,
        CompressibleBrick>::domain()): Likewise.
        (Engine<Dim,T,CompressibleBrickView>::domain()): Likewise.
        (Engine<Dim,T,CompressibleBrickView>::makeOwnCopy()): New
        declaration.
        (ElementProperties<Engine<Dim, T, CompressibleBrickView> >): New
        definition.
        * Engine/RemoteEngine.h (Engine<Dim, T, Remote<Tag> >::Engine):
        Likewise.
        * Layout/Node.h (Node::Node): Reorder member initialization order.
        * NewField/Field.h (Field::physicalCellDomain): Remove unnecessary
        return reference.
        * NewField/FieldEngine/FieldEngine.NoGeometry.h
        (FieldEngine<NoGeometry<Dim>, T, EngineTag>): Add a default
        constructor.
        (FieldEngine<NoGeometry<Dim>, T, EngineTag>::physicalCellDomain):
        s/shrink/shrinkRight/
        (FieldEngine<NoGeometry<Dim>, T, EngineTag>::totalCellDomain):
        Likewise.
        (FieldEngine<NoGeometry<Dim>, T, EngineTag>)::physicalDomain): New
        function.
        (FieldEngine<NoGeometry<Dim>, T, EngineTag>)::totalDomain):
        Likewise.
        * NewField/FieldEngine/FieldEngineBase.ExprEngine.h
        (FieldEngineBase::physicalCellDomain): Likewise.
        * NewField/FieldEngine/FieldEngineBase.h
        (FieldEngineBase::physicalCellDomain): Likewise.
        * Tulip/RemoteProxy.h (RemoteProxy::RemoteProxy): Conditionally
        declaration variable.
        * Utilities/RefCountedBlockPtr.h
        (RefBlockController::RefBlockController): Reorder member
        initializations to reflect declaration order.

Tested on sequential Linux gcc 3.0 by compiling Pooma library and the above program
Approved by     ???you???

Thanks,
Jeffrey D. Oldham
address@hidden

Attachment: May14b.patch
Description: application/applefile

Attachment: May14b.patch
Description: application/text



reply via email to

[Prev in Thread] Current Thread [Next in Thread]