Re: [pooma-dev] RFA: Miscellaneous NewField Related Code Changes

[Scott Haney]

Hi Jeffrey,

This is fine except for one thing:

!   inline const Domain_t &physicalCellDomain() const
      {
!       return shrink(physicalDomain(), 1);
      }

    inline Domain_t totalCellDomain() const
      {
!       return shrink(engine_m.domain(), 1);
      }

    Domain_t physicalDomain() const
--- 254,267 ----
    // This field-engine always has vert-centering and the total domain 
is
    // given by the engine.

!   inline const Domain_t physicalCellDomain() const
      {
!       return shrink(physicalDomain(), guards_m);
      }

    inline Domain_t totalCellDomain() const
      {
!       return shrink(engine_m.domain(), guards_m);
      }

Removing the reference is a good idea, but the "1"'s are correct. 
NoGeometry always has vertex centering and no guard cells so the 
totalCellDomain == physicalCellDomain and they both are 1 smaller than 
the vertex domain in each direction.

Scott

On Thursday, May 3, 2001, at 07:11 PM, Jeffrey Oldham wrote:

> When investigating Dave Nyholm's X.cc and related code, I came across
> minor errors corrected in the attached patch.  OK to commit the changes?
>
> 2001-05-03  Jeffrey D. Oldham  <address@hidden>
>
>         * Engine/IndexFunctionEngine.h (Full Description): Fix grammar
>         error.
>         * Layout/LayoutBase.h (LayoutBaseViewData::LayoutBaseViewData):
>         Reorder initializers according to class declaration order.
>         * Layout/Node.h (Node::Node): Likewise.
>         * Layout/UniformGridLayout.h
>         (UniformGridLayout::UniformGridLayout): Likewise.
>         * NewField/FieldEngine/FieldEngine.NoGeometry.h
>         (FieldEngine::physicalCellDomain): Modify return type by removing
>         reference.  Change second function call argument to match function
>         prototype.
>         (FieldEngine::totalCellDomain): Change second function call
>         argument to match function prototype.
>         * NewField/FieldEngine/FieldEngine.UR.h: Fix typographical errors
>         in initial comments.
>         * Utilities/DataBlockPtr.h
>         (DataBlockController::DataBlockController): Reorder initializers
>         according to class declaration order.
>         * Utilities/RefCountedBlockPtr.h
>         (RefBlockController::RefBlockController): Likewise.
>
> Tested using    Linux gcc 3.0 single-threaded by compiling library
> Approved by     ???you???
>
> Thanks,
> Jeffrey D. Oldham
> address@hidden

03May.patch
Description: application/applefile

03May.patch
Description: application/text

>
--
Scott W. Haney
Development Manager
Proximation LLC
2960 Rodeo Park Drive West
Santa Fe, NM 87505
Voice: 505-424-3809 x101
FAX: 505-438-4161