Re: [Freeipmi-devel] DCMI - get mandatory platform attributes

[Albert Chu]

One change, b/c this is an optional field, I tweaked the change to
ipmi-dcmi to the following.  PLMK if it still works for you.

Index: ipmi-dcmi/ipmi-dcmi.c
===================================================================
--- ipmi-dcmi/ipmi-dcmi.c       (revision 9555)
+++ ipmi-dcmi/ipmi-dcmi.c       (working copy)
@@ -578,6 +578,30 @@
                       val ? "At least 1 present" : "Not present");
     }
 
+  /* In DCMI v1.1 */
+  if (parameter_revision >= 0x02)
+    {
+      int flag;
+
+      if ((flag = fiid_obj_get (obj_cmd_rs,
+                               "temperature_monitoring.sampling_period",
+                               &val)) < 0)
+        {
+          pstdout_fprintf (state_data->pstate,
+                           stderr,
+                           "fiid_obj_get: 
'temperature_monitoring.sampling_period': %s\n",
+                           fiid_obj_errormsg (obj_cmd_rs));
+          goto cleanup;
+        }
+
+      if (flag)
+        {
+          pstdout_printf (state_data->pstate,
+                      "Sampling frequency for Temperature Monitoring      : 
Every %u Second(s)\n",
+                      val);
+        }
+    }
+
   rv = 1;
  cleanup:
   fiid_obj_destroy (obj_cmd_rs);


Al

On Mon, 2013-03-11 at 11:13 -0700, Albert Chu wrote:
> Hey Holger,
> 
> Thanks for the catch.  Just as an FYI,
> 
> libfreeipmi/src/cmds/ipmi-dcmi-cmds.c
> 
> was moved to
> 
> libfreeipmi/cmds/ipmi-dcmi-cmds.c
> 
> in a code re-org awhile back.  Not sure what tree you developed the
> patch against.
> 
> Al
> 
> On Mon, 2013-03-11 at 08:50 +0100, Liebig, Holger wrote:
> > Hi Al,
> > A colleague of mine noticed that with DCMI 1.1 or DCMI 1.5 systems the 
> > ipmi-dcmi --get-dcmi-capability-info seems to be chocking on the additional 
> > byte 5 (Sampling frequency for Temperature Monitoring) which was not 
> > defined in DCMI 1.0
> > 
> > Below is debug output from the unmodified version and attached is a patch 
> > proposal.
> > 
> > Thanks,
> > Holger
> > 
> > 
> > 172.25.50.251: =====================================================
> > 172.25.50.251: IPMI 1.5 Group Extension - Get DCMI Capability Info Response
> > 172.25.50.251: =====================================================
> > 172.25.50.251: RMCP Header:
> > 172.25.50.251: ------------
> > 172.25.50.251: [               6h] = version[ 8b]
> > 172.25.50.251: [               0h] = reserved[ 8b]
> > 172.25.50.251: [              FFh] = sequence_number[ 8b]
> > 172.25.50.251: [               7h] = message_class.class[ 5b]
> > 172.25.50.251: [               0h] = message_class.reserved[ 2b]
> > 172.25.50.251: [               0h] = message_class.ack[ 1b]
> > 172.25.50.251: IPMI Session Header:
> > 172.25.50.251: --------------------
> > 172.25.50.251: [               2h] = authentication_type[ 8b]
> > 172.25.50.251: [        11D1716Ch] = session_sequence_number[32b]
> > 172.25.50.251: [        FFB52DFBh] = session_id[32b]
> > 172.25.50.251: [  BYTE ARRAY ... ] = authentication_code[16B]
> > 172.25.50.251: [ 25h B0h D2h 08h E3h 00h D2h 52h ]
> > 172.25.50.251: [ E3h C1h 7Eh D7h A7h 15h 28h A4h ]
> > 172.25.50.251: [              11h] = ipmi_msg_len[ 8b]
> > 172.25.50.251: IPMI Message Header:
> > 172.25.50.251: --------------------
> > 172.25.50.251: [              81h] = rq_addr[ 8b]
> > 172.25.50.251: [               0h] = rq_lun[ 2b]
> > 172.25.50.251: [              2Dh] = net_fn[ 6b]
> > 172.25.50.251: [              CBh] = checksum1[ 8b]
> > 172.25.50.251: [              20h] = rs_addr[ 8b]
> > 172.25.50.251: [               0h] = rs_lun[ 2b]
> > 172.25.50.251: [              22h] = rq_seq[ 6b]
> > 172.25.50.251: IPMI Command Data:
> > 172.25.50.251: ------------------
> > 172.25.50.251: [               1h] = cmd[ 8b]
> > 172.25.50.251: [               0h] = comp_code[ 8b]
> > 172.25.50.251: [              DCh] = group_extension_identification[ 8b]
> > 172.25.50.251: [               1h] = 
> > dcmi_specification_conformance.major_version[ 8b]
> > 172.25.50.251: [               5h] = 
> > dcmi_specification_conformance.minor_version[ 8b]
> > 172.25.50.251: [               2h] = parameter_revision[ 8b]
> > 172.25.50.251: [             1C7h] = 
> > sel_attributes.number_of_sel_entries[12b]
> > 172.25.50.251: [               0h] = 
> > sel_attributes.record_level_sel_flush_upon_rollover[ 1b]
> > 172.25.50.251: [               1h] = 
> > sel_attributes.entire_sel_flush_upon_rollover[ 1b]
> > 172.25.50.251: [               0h] = sel_attributes.reserved[ 1b]
> > 172.25.50.251: [               1h] = 
> > sel_attributes.sel_automatic_rollover_enabled[ 1b]
> > 172.25.50.251: [               0h] = 
> > identification_attributes.guid_support[ 1b]
> > 172.25.50.251: [               0h] = 
> > identification_attributes.dhcp_host_name_support[ 1b]
> > 172.25.50.251: [               0h] = 
> > identification_attributes.asset_tag_support[ 1b]
> > 172.25.50.251: [               0h] = identification_attributes.reserved[ 5b]
> > 172.25.50.251: [               0h] = 
> > temperature_monitoring.inlet_temperature[ 1b]
> > 172.25.50.251: [               0h] = 
> > temperature_monitoring.processors_temperature[ 1b]
> > 172.25.50.251: [               0h] = 
> > temperature_monitoring.baseboard_temperature[ 1b]
> > 172.25.50.251: [               0h] = temperature_monitoring.reserved[ 5b]
> > 172.25.50.251: IPMI Trailer:
> > 172.25.50.251: --------------
> > 172.25.50.251: [               1h] = checksum2[ 8b]
> > 172.25.50.251: Unexpected Data:
> > 172.25.50.251: ----------------
> > 172.25.50.251: [               Ah] = unexpected_data[ 8b]
> > _______________________________________________
> > Freeipmi-devel mailing list
> > address@hidden
> > https://lists.gnu.org/mailman/listinfo/freeipmi-devel
-- 
Albert Chu
address@hidden
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory