Re: [Freeipmi-devel] ganglia_ipmimonitoring.pl

[Albert Chu]

Hey Chris,

I had another request for such a feature, so I looked at your patch more
closely.  I modified it into the attached patch for the newer
ganglia_ipmi_sensors.pl script.  Will it suit your needs?  The primary
thing I changed in the patch was to not pass a full regex to the script,
only the search/replace expressions within a regex.  We decided having a
user be able to pass an arbitrary string into an eval() was not a good
idea :-)

Yaroslav, will it suit your needs too?

Both patch & script are attached.

Al

P.S.  I haven't committed these anywhere.

On Sat, 2011-01-01 at 20:01 -0800, Christopher Maestas wrote:
> Hi Al,
> 
> 
> I'll try to work on back porting this against that code base sometime
> next week if that's OK.
> 
> 
> Thanks,
> -cdm
> 
> On Mon, Dec 27, 2010 at 10:46 AM, Al Chu <address@hidden> wrote:
>         Hey Chris,
>         
>         Patch for the most part looks fine.  With the FreeIPMI 1.0.0
>         beta
>         already out, why don't we aim this patch for the new Ganglia
>         ipmi
>         sensors perl script that will be released along with it.
>         (ipmimonitoring has been deprecated for a new
>         --output-event-state
>         option in ipmi-sensors).
>         
>         Would you like to do the forward port, or should I?
>         
>         Al
>         
>         
>         On Tue, 2010-12-21 at 21:35 -0800, Christopher Maestas wrote:
>         > Here's a stab at adding a -e flag that lets you run a perl
>         regex
>         > against the hostname.  Then you can run:
>         >
>         >
>         > ./ganglia_ipmimonitoring.pl -e 's/^mp-//g' -h mp-cn[1-4] -D
>         -d
>         >
>         >
>         > I'm sure it could be cleaned up further or restricted to
>         only
>         > doing/checking for search and replace expressions.
>         >
>         >
>         > -cdm
>         >
>         > On Tue, Dec 21, 2010 at 2:20 PM, Al Chu <address@hidden>
>         wrote:
>         >         Hi Chris,
>         >
>         >         Hmmm.  I'm not really sure how we could/should do
>         that.
>         >          Perhaps some
>         >         other option would tell the script to create/remove
>         the prefix
>         >         before
>         >         passing it up to ganglia?
>         >
>         >         Al
>         >
>         >
>         >         On Tue, 2010-12-21 at 10:52 -0800, Christopher
>         Maestas wrote:
>         >         > Any thought given to translating the hostlist from
>         the
>         >         management
>         >         > processor name to a real device name?  For
>         example:
>         >         >       * device name is mp-cn[1-2] and hostname is
>         cn[1-2]
>         >         >
>         >         >
>         >         > ./ganglia_ipmimonitoring.pl -D -d -h mp-cn[1-2] |
>         sed -e
>         >         's/mp-//g'
>         >         >
>         >         >
>         >         > but I don't think that will do what I want ...
>         >
>         >         --
>         >         Albert Chu
>         >         address@hidden
>         >         Computer Scientist
>         >         High Performance Systems Division
>         >         Lawrence Livermore National Laboratory
>         >
>         >
>         >
>         
>         --
>         
>         Albert Chu
>         address@hidden
>         Computer Scientist
>         High Performance Systems Division
>         Lawrence Livermore National Laboratory
>         
>         
> 
> 
-- 
Albert Chu
address@hidden
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory

gangliareplaceoption.patch
Description: Text Data

ganglia_ipmi_sensors.pl
Description: Perl program