[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Freehoo-devel] Re: Doubt
From: |
Anand Babu |
Subject: |
Re: [Freehoo-devel] Re: Doubt |
Date: |
Mon, 23 Aug 2004 20:10:26 -0700 |
User-agent: |
Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux) |
,----[ "K. Viswanathan" <address@hidden> ]
| 1. Flow control now from yahoo-backend.c (as same as
| sample-client.c) which could simply use all our
| existing readline/guile extensions.
|
| 2. yahoo-wrapper.[ch] is now yahoo-adapter.[ch]
| 3. yahoo2-callbacks.[ch] is removed.
| 4. messenger.c is NOT yet removed.
|
| 5. Still using sample_client.c's code to prompt for
| user-id/passwd. Use log-level 0 (for clean screen)
| when its asked. All this are temporary. Hope to do
| more cleanups in the coming days.
`----
Good work Visu.
,----[ "K. Viswanathan" <address@hidden> ]
| 6. I was forced to checkin all Makefile.in also as
| part of the src/Makefile.am changes (still I use SuSE
| for dev). If it doesn't work, please run ./refresh
| from top and commit once again.
`----
Actually these files are on the CVS just for convenience. I am
removing them from CVS. Also renaming ./refresh to
./autogen.sh. Every developer is required to run this script to
generate a fresh local build scripts.
Happy Hacking,
Anand Babu.
--- Anand Babu <address@hidden> wrote:
> ,----[ "K. Viswanathan" <address@hidden> ]
> | Hi AB
> |
> | I have a doubt. I am right now working on code
> clean-up.
> |
> | Existing check-in had too many changes in
> sample_client.c. But now I
> | have reached the same stage with minimal changes
> in
> | sample_client.c. This is what
> | I did:
> |
> | 1. Moved global declarations (struct), MACROS to a
> header file.
> | 2. Splited main function to messenger_main and
> main_loop.
> | 3. Merged the main_loop with our existing
> main_loop in messenger.c,
> | so that readline works using interpreter.
> |
> | Now, the doubt is, how to name this file? This has
> 3 different
> | functionalities which respectively should go to
> messenger.c,
> | yahoo2-callbacks.c and yahoo-wrapper.c
> |
> | 1. Move all the callbacks to yahoo2-callbacks.c,
> move
> | messenger_main, main_loop to messenger.c and merge
> the rest with
> | yahoo-wrapper.c. Existing check-in is exactly
> this.
> | Plus: No confusion.
> | Minus: Not a good idea since sample_client.c is
> facing
> | too many modifications.
> |
> | 2. Keep sample_client.c (after renaming) as it is
> with minimal
> | modifications. Plus: Easy future migration and
> yahoo2-callbacks.c
> | can be dropped.
> | Minus: 3 functionalities in 1 file and how to name
> | this?
> |
> | Note: Existing yahoo-wrapper.c cannot be dropped
> as many functions
> | are still needed.
> `----
> Hi Visu,
> Excellent question. Looks like you got a good
> understanding of the
> core now.
>
> Here is what I will do:
> - Move yahoo-wrapper.c as yahoo-adapter.c
> - Keep all contents from sample-client.c inside
> yahoo-backend.c
> - messenger.c will dissolve into yahoo-backend.c
>
> There is a shift in strategy now. Originally Freehoo
> was designed to
> control the flow. Protocol handling was easier and
> simpler. Over time
> things have changed. Now we find making
> modifications to Freehoo core
> easier than libyahoo2 code. To have a design which
> requires easy
> integration of libyahoo2, we need to move the
> control of flow to
> yahoo-backend.c.
>
> More precisely yahoo-backend.c will view Freehoo
> core as a set of
> utility procedures (like a library).
>
> Write functions which requires guile or readline
> integration inside
> yahoo-adapter.c and call them from yahoo-backend.c
>
> Do you get the picture?
>
> Happy Hacking
> --
> Anand Babu
> Free as in Freedom <www.gnu.org>
>
__________________________________
Do you Yahoo!?
Yahoo! Mail - 50x more storage than other providers!
http://promotions.yahoo.com/new_mail
_______________________________________________
Freehoo-devel mailing list
address@hidden
http://lists.nongnu.org/mailman/listinfo/freehoo-devel
--
Anand Babu
Free as in Freedom <www.gnu.org>